incubator-xap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtu...@apache.org
Subject svn commit: r498805 - in /incubator/xap/trunk/codebase/src/xap/widgets: ListBox.js XapComboBox.js
Date Mon, 22 Jan 2007 21:15:07 GMT
Author: mturyn
Date: Mon Jan 22 13:15:06 2007
New Revision: 498805

URL: http://svn.apache.org/viewvc?view=rev&rev=498805
Log:
Fixed error that was readjusting heights in IE7 to fix a bug that only shows up in IE6.

Modified:
    incubator/xap/trunk/codebase/src/xap/widgets/ListBox.js
    incubator/xap/trunk/codebase/src/xap/widgets/XapComboBox.js

Modified: incubator/xap/trunk/codebase/src/xap/widgets/ListBox.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/widgets/ListBox.js?view=diff&rev=498805&r1=498804&r2=498805
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/widgets/ListBox.js (original)
+++ incubator/xap/trunk/codebase/src/xap/widgets/ListBox.js Mon Jan 22 13:15:06 2007
@@ -67,7 +67,7 @@
 			// under Mozilla, no problem anywhere if 
 			// multiple selection is off, since losing the
 			// old selections is exactly what is desired there...
-			if( window.netscape ){	
+			if( navigator.appVersion.indexOf("MSIE 6") > -1 ){	
 				this.raw_addChild(child) ;
 				return ;
 			}

Modified: incubator/xap/trunk/codebase/src/xap/widgets/XapComboBox.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/widgets/XapComboBox.js?view=diff&rev=498805&r1=498804&r2=498805
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/widgets/XapComboBox.js (original)
+++ incubator/xap/trunk/codebase/src/xap/widgets/XapComboBox.js Mon Jan 22 13:15:06 2007
@@ -29,7 +29,7 @@
 	addChild: function(child) {
     	xap.widgets.XapComboBox.superclass.addChild.call(this, child); /* add dojo widget to
dojo widget */
     	this.child = child ;
-    	this.fixIeHeight() ;
+    	this.fixIe6Height() ;
 	},
 	
     
@@ -85,12 +85,12 @@
 		this.child.setHeight( value ) ;
 	}	
 	
-	this.fixIeHeight() ;			
+	this.fixIe6Height() ;			
 }
 
 
-xap.widgets.XapComboBox.prototype.fixIeHeight = function() {
-	if( !window.netscape && this.child && this.child.select && this.child.select.clientHeight
){
+xap.widgets.XapComboBox.prototype.fixIe6Height = function() {
+	if( (navigator.appVersion.indexOf("MSIE 6") > -1)  && this.child && this.child.select
&& this.child.select.clientHeight ){
 		this.domNode.style.height = this.child.select.clientHeight +"px" ;
 	}
 }	



Mime
View raw message