incubator-xap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmarga...@apache.org
Subject svn commit: r471057 - in /incubator/xap/trunk/src/xap/bridges/dojo: MenuBarBridge.js MenuBarItemBridge.js MenuBridge.js MenuItemBridge.js
Date Fri, 03 Nov 2006 23:36:35 GMT
Author: jmargaris
Date: Fri Nov  3 15:36:34 2006
New Revision: 471057

URL: http://svn.apache.org/viewvc?view=rev&rev=471057
Log:
Minor bug fix for xinclude children giving an error

Modified:
    incubator/xap/trunk/src/xap/bridges/dojo/MenuBarBridge.js
    incubator/xap/trunk/src/xap/bridges/dojo/MenuBarItemBridge.js
    incubator/xap/trunk/src/xap/bridges/dojo/MenuBridge.js
    incubator/xap/trunk/src/xap/bridges/dojo/MenuItemBridge.js

Modified: incubator/xap/trunk/src/xap/bridges/dojo/MenuBarBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/bridges/dojo/MenuBarBridge.js?view=diff&rev=471057&r1=471056&r2=471057
==============================================================================
--- incubator/xap/trunk/src/xap/bridges/dojo/MenuBarBridge.js (original)
+++ incubator/xap/trunk/src/xap/bridges/dojo/MenuBarBridge.js Fri Nov  3 15:36:34 2006
@@ -34,6 +34,8 @@
  
 xap.bridges.dojo.MenuBarBridge= function() {
 	xap.bridges.dojo.DojoWidgetBridge.call(this);
+	
+	//IMPORTANT should't this property be set on 'this' rather than prototype
 	dojo.widget.MenuBar2.prototype.disabled = false;
 }
 
@@ -42,6 +44,7 @@
 				"xap.bridges.dojo.DojoWidgetBridge"						
 );
 
+//IMPORTANT remove this? Just a pass through
 xap.bridges.dojo.MenuBarBridge.prototype.init = function() {
 	xap.bridges.dojo.DojoWidgetBridge.prototype.init.call(this);
 }
@@ -50,6 +53,8 @@
     return "MenuBar2" ;
 }
 
+//IMPORTANT should't these property be set on 'this' rather than prototype?
+//won't these get shared among all menubars in application?
 dojo.widget.MenuBar2.prototype.enabled = true;
 dojo.widget.MenuBar2.prototype.height = null;
 

Modified: incubator/xap/trunk/src/xap/bridges/dojo/MenuBarItemBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/bridges/dojo/MenuBarItemBridge.js?view=diff&rev=471057&r1=471056&r2=471057
==============================================================================
--- incubator/xap/trunk/src/xap/bridges/dojo/MenuBarItemBridge.js (original)
+++ incubator/xap/trunk/src/xap/bridges/dojo/MenuBarItemBridge.js Fri Nov  3 15:36:34 2006
@@ -44,6 +44,7 @@
 				"xap.bridges.dojo.DojoWidgetBridge"						
 );
 
+//IMPORTANT these on the prototype is a bad idea?
 dojo.widget.MenuBarItem2.prototype.enabled = true;
 dojo.widget.MenuBarItem2.prototype.visible = true;
 
@@ -72,6 +73,8 @@
 	}	
 }
 
+
+//IMPORTANT remove this? simple pass through
 xap.bridges.dojo.MenuBarItemBridge.prototype.init = function() {
 	xap.bridges.dojo.DojoWidgetBridge.prototype.init.call(this);
 }

Modified: incubator/xap/trunk/src/xap/bridges/dojo/MenuBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/bridges/dojo/MenuBridge.js?view=diff&rev=471057&r1=471056&r2=471057
==============================================================================
--- incubator/xap/trunk/src/xap/bridges/dojo/MenuBridge.js (original)
+++ incubator/xap/trunk/src/xap/bridges/dojo/MenuBridge.js Fri Nov  3 15:36:34 2006
@@ -44,7 +44,7 @@
 );
 
 
-
+//IMPORTANT remove this? simple pass through
 xap.bridges.dojo.MenuBridge.prototype.init = function() {
 	xap.bridges.dojo.DojoWidgetBridge.prototype.init.call(this);
 }

Modified: incubator/xap/trunk/src/xap/bridges/dojo/MenuItemBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/bridges/dojo/MenuItemBridge.js?view=diff&rev=471057&r1=471056&r2=471057
==============================================================================
--- incubator/xap/trunk/src/xap/bridges/dojo/MenuItemBridge.js (original)
+++ incubator/xap/trunk/src/xap/bridges/dojo/MenuItemBridge.js Fri Nov  3 15:36:34 2006
@@ -25,6 +25,7 @@
 
 Xap.require("dojo.widget.Menu2");
 Xap.require("xap.session.ClientEvent"); 
+Xap.require('xap.bridges.dojo.DojoWidgetBridge');
 
  /**
  * @fileoverview



Mime
View raw message