incubator-xap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mtu...@apache.org
Subject svn commit: r430464 - /incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js
Date Thu, 10 Aug 2006 18:03:56 GMT
Author: mturyn
Date: Thu Aug 10 11:03:55 2006
New Revision: 430464

URL: http://svn.apache.org/viewvc?rev=430464&view=rev
Log:
Fixed a bug in determining whether an initial property were allowed for a widget---should
look at the XAL version of the property name (e.g., "id" rather than "widgetId") because that's
less likely to change between widgets and toolkits.

Modified:
    incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js

Modified: incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js?rev=430464&r1=430463&r2=430464&view=diff
==============================================================================
--- incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js (original)
+++ incubator/xap/trunk/src/xap/bridges/dojo/DojoWidgetBridge.js Thu Aug 10 11:03:55 2006
@@ -302,12 +302,14 @@
 				name = mapper[xalName] ;
 			}
 			//Doesn't do much here, but for subclasses:
-			if( this.allowsInitialProperty(name)){
-				// What about the value?  If necessary we could introduce 
-				// an object holding a map-to name and a callback used
-				// to get the right value....
+			if( this.allowsInitialProperty(xalName)){
+				// What about the value?  
 				var xalValue = arrAttributes[ii].nodeValue ;
 				//...but we'll just do a little bit here:
+				//If necessary we could introduce 
+				// an object holding a map-to name and a callback used
+				// to get the right value, we could easily map from on to the other
+				// in complicated ways, but not here, not now:
 				var value = xalValue ;
 				if (xalValue == "true"){
 					value = true ;



Mime
View raw message