incubator-wookie-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Wilson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WOOKIE-42) Wookie rewrites HTML start file incorrectly when injecting JavaScript, where there are self-closing script tags
Date Mon, 09 Nov 2009 10:00:33 GMT

    [ https://issues.apache.org/jira/browse/WOOKIE-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774923#action_12774923
] 

Scott Wilson commented on WOOKIE-42:
------------------------------------

There is a bug and a patch on the HtmlCleaner Sourceforge site:

http://sourceforge.net/tracker/?func=detail&aid=2038023&group_id=183053&atid=903696

However its not clear if the package is still being maintained; last commits were over a year
ago. 

It may be worth considering switching to Neko or JTidy, or to just inject the scripts directly
into the html as a string rather than try to use a DOM-based approach.

> Wookie rewrites HTML start file incorrectly when injecting JavaScript, where there are
self-closing script tags
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: WOOKIE-42
>                 URL: https://issues.apache.org/jira/browse/WOOKIE-42
>             Project: Wookie
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 0.8.1
>            Reporter: Scott Wilson
>            Priority: Minor
>             Fix For: 0.8.1
>
>         Attachments: tweetwatch.wgt
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> When uploading a widget which has multiple <script> tags in the <head> of
the start document, Wookie incorrectly repositions these within the file when it injects the
wookie wrapper scripts. For example, this:
> <head>
>     <script type="text/javascript" src="js/wmpkit.js"/>
>     <script type="text/javascript" src="js/json2.js"/>
>     <script type="text/javascript" src="js/script.js"></script>
>   </head>
>   <body>
>     <h1><img src="images/tweetWatch.png" alt="tweetWatch" /></h1>
>     <div id="content"></div>
>   </body>
> </html>
> Becomes:
> 	<head>
> 		<script type="text/javascript" src="/wookie/dwr/util.js"></script>
> 		<script type="text/javascript" src="/wookie/dwr/engine.js"></script>
> 		<script type="text/javascript" src="/wookie/dwr/interface/WidgetImpl.js"></script>
> 		<script type="text/javascript" src="/wookie/shared/js/wookie-wrapper.js"></script>
> 		<script type="text/javascript" src="js/script.js"></script>
> 	</head>
> 	<body>
> 		<script type="text/javascript" src="js/wmpkit.js">
> 			<script type="text/javascript" src="js/json2.js">
> 				<h1>
> 					<img src="images/tweetWatch.png" alt="tweetWatch" />
> 				</h1>
> 				<div id="content"></div>
> 			</script>
> 		</script>
> 	</body>
> </html>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message