Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 738FF200CD4 for ; Sat, 29 Jul 2017 15:43:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 71C9F165007; Sat, 29 Jul 2017 13:43:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B8416164F6E for ; Sat, 29 Jul 2017 15:43:27 +0200 (CEST) Received: (qmail 20312 invoked by uid 500); 29 Jul 2017 13:43:26 -0000 Mailing-List: contact wave-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: wave-dev@incubator.apache.org Delivered-To: mailing list wave-dev@incubator.apache.org Received: (qmail 20300 invoked by uid 99); 29 Jul 2017 13:43:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Jul 2017 13:43:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0F8E9C02D5 for ; Sat, 29 Jul 2017 13:43:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.38 X-Spam-Level: ** X-Spam-Status: No, score=2.38 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3Wb3i4Uhx7eY for ; Sat, 29 Jul 2017 13:43:17 +0000 (UTC) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E529D5F6D2 for ; Sat, 29 Jul 2017 13:43:16 +0000 (UTC) Received: by mail-lf0-f53.google.com with SMTP id y15so99846188lfd.5 for ; Sat, 29 Jul 2017 06:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=qfWTlGKTr3IO/vPizozxgxkdG72Rn9hHtqmLDVbTCFI=; b=DnCXriNwfLjYMi3VxvFbVwdBfHAIGdiLhy+/p9M0kWx/WqCwJAtdesJFydI+UT+PJj 6ER20RmIDqvY+zgfvmNFnFGF8IKsvJQT0LkS/KQCcZ3JfyNswtNDBW5aBaKYm73raAHP tYwVs9+z/cPOeY7INWa2yYdUEFX5/FsUUjZqwERbIrXBFKlyocUtRZ9ks3dIEXr485M6 NZe+wOio+kAe24dav7qpo4WhvE3zkQin1mbV/IcP76Q8o3UdLMmYDJ1VCS4fZSbUWUhD SoR8A9D0NS2tAsD5/ZaukCOhGSowJP87g5DIPDi7aBSgJUuH1tAoeEsL8wRLaOZGQYnY yvUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=qfWTlGKTr3IO/vPizozxgxkdG72Rn9hHtqmLDVbTCFI=; b=AC6JjC6LLJZWUlmIAki/OVxLyl/W9YceK7iyAo/n0s/stM6SJvfLbzpxSwVjmOh5dV VTZgsOfLp2yX05B+jbpnzjA5KC8nCa+d2iw4ngmC1Aiu12oxVSh3d0cjcjRwMnEetN+k ja6KuQqFBtTXdo9betfkcmNBnLiIoaDFu5FfKDcxhHov4ykxuyIWul42Ef8dmHJJzdG6 MZBqEtPKWcjTe1FORXiRX2Y5nv/JhnL2eOvEWzB2RL1IAOFsmAQqIV9LnxARSYhstjoJ DZMcOp1L51m90LxW0xH2Qpa0So8eX81G5HlCGe37HiKNiGRmqWf4Qdc7cnMLxzD9UImK smaw== X-Gm-Message-State: AIVw110G+aIQFdqtwjjeHUk0ZpmGT/Pwj6MBgN8FCC8gnfY/8LhyXDJN rCYTRZjls5ms83Dygkt2jc8+HZr4Q6b2 X-Received: by 10.46.9.135 with SMTP id 129mr4326845ljj.177.1501335795532; Sat, 29 Jul 2017 06:43:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.88.70 with HTTP; Sat, 29 Jul 2017 06:42:55 -0700 (PDT) In-Reply-To: References: From: Peter Warrington Date: Sat, 29 Jul 2017 14:42:55 +0100 Message-ID: Subject: Re: Peer review: Make login page more user friendly. To: wave-dev@incubator.apache.org Content-Type: multipart/alternative; boundary="001a114b1326c807dc055574fa79" archived-at: Sat, 29 Jul 2017 13:43:28 -0000 --001a114b1326c807dc055574fa79 Content-Type: text/plain; charset="UTF-8" Hello! The Pull request is at: https://github.com/apache/incubator-wave/pull/26 Thank you! Peter On Sat, Jul 29, 2017 at 2:33 PM, Peter Warrington wrote: > Hello! Thanks for your reply. > > One of the changes I made was to make it work on mobiles as that is the > direction I see WIAB going. Also, it drew too much attention to the top bar > when we want most of the attention going to the login box. It also makes > the Screenshot more prominent so that the user can easily figure out what > WIAB does. I am in the process of submitting a Pull request now. > > Thank you! > > Peter. > > On Sat, Jul 29, 2017 at 1:27 PM, Yuri Z wrote: > >> I take look - it does look more modern, but it is hard to judge for me as >> I >> am not a UI expert. Can you maybe explain a bit your considerations behind >> the change? >> >> On Sat, Jul 29, 2017 at 2:38 PM Yuri Z wrote: >> >> > Hi Peter >> > Thanks! I ll take a look. >> > Recently we switched to GitHub pull requests instead of Review Board to >> > manage the changes. Would you like to create a PR for out GitHub mirror >> > repo? >> > https://github.com/apache/incubator-wave >> > >> > On Tue, Jul 25, 2017 at 8:56 PM Peter Warrington < >> mildlygoodapps@gmail.com> >> > wrote: >> > >> >> I have created a review at: https://reviews.apache.org/r/61115/ which >> >> aims >> >> to make the login page more user friendly. This is my first Peer >> review to >> >> this project and any input I would be greatful for. >> >> >> >> - >> >> >> >> Peter >> >> >> > >> > > --001a114b1326c807dc055574fa79--