incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Warrington <mildlygooda...@gmail.com>
Subject Re: Peer review: Make login page more user friendly.
Date Sat, 29 Jul 2017 13:42:55 GMT
Hello!

The Pull request is at: https://github.com/apache/incubator-wave/pull/26

Thank you!

Peter

On Sat, Jul 29, 2017 at 2:33 PM, Peter Warrington <mildlygoodapps@gmail.com>
wrote:

> Hello! Thanks for your reply.
>
> One of the changes I made was to make it work on mobiles as that is the
> direction I see WIAB going. Also, it drew too much attention to the top bar
> when we want most of the attention going to the login box. It also makes
> the Screenshot more prominent so that the user can easily figure out what
> WIAB does. I am in the process of submitting a Pull request now.
>
> Thank you!
>
> Peter.
>
> On Sat, Jul 29, 2017 at 1:27 PM, Yuri Z <vega113@gmail.com> wrote:
>
>> I take look - it does look more modern, but it is hard to judge for me as
>> I
>> am not a UI expert. Can you maybe explain a bit your considerations behind
>> the change?
>>
>> On Sat, Jul 29, 2017 at 2:38 PM Yuri Z <vega113@gmail.com> wrote:
>>
>> > Hi Peter
>> > Thanks! I ll take a look.
>> > Recently we switched to GitHub pull requests instead of Review Board to
>> > manage the changes. Would you like to create a PR for out GitHub mirror
>> > repo?
>> > https://github.com/apache/incubator-wave
>> >
>> > On Tue, Jul 25, 2017 at 8:56 PM Peter Warrington <
>> mildlygoodapps@gmail.com>
>> > wrote:
>> >
>> >> I have created a review at: https://reviews.apache.org/r/61115/ which
>> >> aims
>> >> to make the login page more user friendly. This is my first Peer
>> review to
>> >> this project and any input I would be greatful for.
>> >>
>> >> -
>> >>
>> >> Peter
>> >>
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message