incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zmyaro <...@git.apache.org>
Subject [GitHub] incubator-wave issue #26: Make log-in page more friendly.
Date Sat, 29 Jul 2017 14:43:03 GMT
Github user zmyaro commented on the issue:

    https://github.com/apache/incubator-wave/pull/26
  
    I like your stated goals, but I am not sure how well the changes accomplish them.
    
    > it drew too much attention to the top bar when we want most of the attention going
to the login box.
    
    The layout in the screenshots has a tall top bar with a lot of empty space and a login
box that will almost always be pushed “below the fold”.  That is not too much of a problem
since you have a “Sign in” FAB, but I am not sure whether it matches your stated intent.
    
    More generally, I am concern that this design does not seem to have a cohesive design
language, but if your goal is just an improved layout, then that can be addressed later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message