incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wisebaldone <...@git.apache.org>
Subject [GitHub] incubator-wave pull request #25: Updated builds to use proto3 libraries.
Date Mon, 03 Jul 2017 07:10:49 GMT
Github user wisebaldone commented on a diff in the pull request:

    https://github.com/apache/incubator-wave/pull/25#discussion_r125221637
  
    --- Diff: pst/src/main/proto/google/protobuf/descriptor.proto ---
    @@ -37,10 +37,14 @@
     // without any other information (e.g. without reading its imports).
     
     
    +syntax = "proto2";
     
     package google.protobuf;
    +option go_package = "github.com/golang/protobuf/protoc-gen-go/descriptor;descriptor";
     option java_package = "com.google.protobuf";
     option java_outer_classname = "DescriptorProtos";
    +option csharp_namespace = "Google.Protobuf.Reflection";
    --- End diff --
    
    I do not feel comfortable editing this as its the original file from google which we have
listed in the license.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message