Mailing-List: contact wave-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: wave-dev@incubator.apache.org
From: vega113 <git@git.apache.org>
To: wave-dev@incubator.apache.org
Reply-To: wave-dev@incubator.apache.org
References: <git-pr-24-incubator-wave@git.apache.org>
In-Reply-To: <git-pr-24-incubator-wave@git.apache.org>
Subject: [GitHub] incubator-wave pull request #24: Workaround WAVE-446
Content-Type: text/plain
Message-Id: <20170503180814.2C9CEE04AA@git1-us-west.apache.org>
Date: Wed,  3 May 2017 18:08:14 +0000 (UTC)
archived-at: Wed, 03 May 2017 18:08:17 -0000

Github user vega113 commented on a diff in the pull request:

    https://github.com/apache/incubator-wave/pull/24#discussion_r114601665
  
    --- Diff: wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java ---
    @@ -154,7 +155,15 @@ public synchronized void submitResponse(WaveletName waveletName, HashedVersion v
         // Forward any queued deltas.
         List<TransformedWaveletDelta> filteredDeltas =  filterOwnDeltas(state.heldBackDeltas, state);
         if (!filteredDeltas.isEmpty()) {
    -      sendUpdate(waveletName, filteredDeltas, null);
    +      //
    +      // Workaround for WAVE-446 (pablojan@apache.org)
    +      //	
    +      for (TransformedWaveletDelta delta: filteredDeltas) {
    +        List<TransformedWaveletDelta> singleDeltaList = new ArrayList<TransformedWaveletDelta>(1);
    +    	singleDeltaList.add(delta);
    +        sendUpdate(waveletName, singleDeltaList, null);
    +	  }
    --- End diff --
    
    Looks like the bracket could use formatting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---