incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vega113 <...@git.apache.org>
Subject [GitHub] incubator-wave pull request #24: Workaround WAVE-446
Date Thu, 04 May 2017 11:22:37 GMT
Github user vega113 commented on a diff in the pull request:

    https://github.com/apache/incubator-wave/pull/24#discussion_r114750100
  
    --- Diff: wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
    @@ -154,7 +155,15 @@ public synchronized void submitResponse(WaveletName waveletName,
HashedVersion v
         // Forward any queued deltas.
         List<TransformedWaveletDelta> filteredDeltas =  filterOwnDeltas(state.heldBackDeltas,
state);
         if (!filteredDeltas.isEmpty()) {
    -      sendUpdate(waveletName, filteredDeltas, null);
    +      //
    +      // Workaround for WAVE-446 (pablojan@apache.org)
    +      //	
    +      for (TransformedWaveletDelta delta: filteredDeltas) {
    +        List<TransformedWaveletDelta> singleDeltaList = new ArrayList<TransformedWaveletDelta>(1);
    --- End diff --
    
    I guess let's just implement a naive splitter that packs every delta into a separate list.
I think the better solution would be to take the client-server implementation from the wiab
pro. They totally rewrote and improved it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message