Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A64D3200C37 for ; Sun, 19 Mar 2017 11:41:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9A4BC160B7D; Sun, 19 Mar 2017 10:41:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DABA2160B6E for ; Sun, 19 Mar 2017 11:41:31 +0100 (CET) Received: (qmail 45835 invoked by uid 500); 19 Mar 2017 10:41:30 -0000 Mailing-List: contact wave-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: wave-dev@incubator.apache.org Delivered-To: mailing list wave-dev@incubator.apache.org Received: (qmail 45824 invoked by uid 99); 19 Mar 2017 10:41:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Mar 2017 10:41:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 69B28DFF56; Sun, 19 Mar 2017 10:41:30 +0000 (UTC) From: pablojan To: wave-dev@incubator.apache.org Reply-To: wave-dev@incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-wave issue #19: Removal / Update of Dependencies and other QOL Content-Type: text/plain Message-Id: <20170319104130.69B28DFF56@git1-us-west.apache.org> Date: Sun, 19 Mar 2017 10:41:30 +0000 (UTC) archived-at: Sun, 19 Mar 2017 10:41:32 -0000 Github user pablojan commented on the issue: https://github.com/apache/incubator-wave/pull/19 My apologies for the delayed review. I tried the PR and LGTM: Following tasks ran successfully: testAll, jar, run, createDist I performed following tests: Extracted distributions/wave-0.4.2.zip, and ran ./bin/wave Created an user and a new wave. Everything worked Ok. Text editor worked in Chrome. User avatars didn't show. Server stopped (Ctrl+C) Changed following props in config/reference.app, delta_store_type : mongodb profile_fetcher_type : gravatar Ran again ./bin/wave Created new wave. Everything worked Ok, User avatars are shown now (Gravatar). Wavelets delta appears in mongoDB. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---