incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael MacFadden <michael.macfad...@gmail.com>
Subject Re: Github pull requests discussion
Date Tue, 26 Apr 2016 01:20:14 GMT
I don't know that we have to "move" to git hub pull requests. We can support both I guess?

~Michael

> On Apr 24, 2016, at 8:38 AM, Evan Hughes <ehugh1@gmail.com> wrote:
> 
> Regarding #1 see the commits I pushed today.
>> On 25/04/2016 12:58 AM, "Yuri Z" <vega113@gmail.com> wrote:
>> 
>> I think we can try it.
>> I see a few cons though:
>> 1. I don't know how to make the asfgit close abandoned pull requests.
>> 2. There's no integration between Jira and github pull requests.
>> 3. There's no link to code review that we can out into commit message, thus
>> providing context for the change. This might be ok for a project that uses
>> Github exclusively,  but for project that uses it only as a mirror - might
>> be tricky. Also, Apache Foundation has no control over GitHub and they can
>> discontinue their service at any second.
>> 
>> The biggest pro for pull requests is that it is easier and can handle
>> binary data - like adding jars/images to source.
>> Anyway, I think I would prefer Review Board, but I won't turn away pull
>> requests too.
>> 
>> On Sun, Apr 24, 2016 at 4:03 PM ๏̯͡๏ Guido Barosio <gbarosio@gmail.com>
>> wrote:
>> 
>>> +1
>>> 
>>>> On Sunday, April 24, 2016, Pablo Ojanguren <pablojan@gmail.com> wrote:
>>>> 
>>>> +1
>>>> 
>>>> 2016-04-24 6:25 GMT+02:00 Andreas Kotes <count-apache.org@flatline.de
>>>> <javascript:;>>:
>>>> 
>>>>> Hi,
>>>>> 
>>>>>> On Sun, Apr 24, 2016 at 04:12:52AM +0000, Evan Hughes wrote:
>>>>>> I think we should move to github pull requests as the standardised
>>> way
>>>>> for
>>>>>> all our repos. ATM we have docs and android client on pull requests
>>> and
>>>>> the
>>>>>> main repo is through review board. Its easier to get automated
>>> testing
>>>>> and
>>>>>> is generally easier to submit reviews through pull requests (for
me
>>>>>> personally).
>>>>>> 
>>>>>> Would love to hear everyone's opinion and after a couple of days
>>> have a
>>>>>> vote.
>>>>> 
>>>>> github is the way to go, all my current OSS workflows are based
>> around
>>>> it.
>>>>> 
>>>>>  count
>>>>> 
>>>>> --
>>>>> Andreas 'count' Kotes
>>>>> Taming computers for humans since 1990.
>>>>> "Don't ask what the world needs. Ask what makes you come alive, and
>> go
>>> do
>>>>> it.
>>>>> Because what the world needs is people who have come alive." --
>> Howard
>>>>> Thurman
>>> 
>>> 
>>> --
>>> 
>>> 
>>> [image: --]
>>> 
>>> Guido Barosio
>>> [image: https://]about.me/gbarosio
>>> <
>> https://about.me/gbarosio?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links
>> 

Mime
View raw message