incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Evan Hughes <ehu...@gmail.com>
Subject Re: Review Request 43301: PST: add example code and some documentation
Date Sun, 07 Feb 2016 13:54:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43301/#review118177
-----------------------------------------------------------



To build on what yuri said on the github. 

Having the example in the source files isnt end of the world as this is where the documentation
is located. When the documentation is expanded apon and include in the docs repo then I agree
but I dont see a problem with it being included here atm.


In other news, do you mind squashing your commits so we only need to review one chunk ;).

- Evan Hughes


On Feb. 7, 2016, 1:02 p.m., Andreas Kotes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43301/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2016, 1:02 p.m.)
> 
> 
> Review request for wave.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> PST: add example code and some documentation
> 
> 
> Diffs
> -----
> 
>   pst/README.md PRE-CREATION 
>   pst/example/.gitignore PRE-CREATION 
>   pst/example/beans.st PRE-CREATION 
>   pst/example/example.proto PRE-CREATION 
>   pst/example/example.st PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43301/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Kotes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message