incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Kotes" <count-apache....@flatline.de>
Subject Re: Review Request 41700: vagrant file for apache wave
Date Thu, 24 Dec 2015 22:35:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41700/#review111882
-----------------------------------------------------------

Ship it!


The Win10 vagrant config doesn't do much, as announced.

I +1 the Ship It (as is or with the mostly cosmetic adjustments suggested), this is an nice
basis for further iterations!

- Andreas Kotes


On Dez. 24, 2015, 4:19 vorm., Evan Hughes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41700/
> -----------------------------------------------------------
> 
> (Updated Dez. 24, 2015, 4:19 vorm.)
> 
> 
> Review request for wave, Ali Lown and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> Adds vagrant config for linux and windows vm's
> 
> 
> Diffs
> -----
> 
>   .gitignore b8ef753 
>   README.md 3be1780 
>   Vagrantfile PRE-CREATION 
>   release/artifact-sign.sh 004d5f0 
>   scripts/release/artifact-sign.sh PRE-CREATION 
>   scripts/vagrant/application.conf PRE-CREATION 
>   scripts/vagrant/setup-fedora.sh PRE-CREATION 
>   scripts/vagrant/setup-ubuntu.sh PRE-CREATION 
>   scripts/vagrant/setup-win-choco.cmd PRE-CREATION 
>   scripts/vagrant/setup-win.cmd PRE-CREATION 
>   wave/build.gradle ca39a6d 
> 
> Diff: https://reviews.apache.org/r/41700/diff/
> 
> 
> Testing
> -------
> 
> Can run server in all vm's (fedora, ubuntu, win 10)
> 
> 
> Thanks,
> 
> Evan Hughes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message