incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Kotes" <count-apache....@flatline.de>
Subject Re: Review Request 41700: vagrant file for apache wave
Date Thu, 24 Dec 2015 20:16:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41700/#review111877
-----------------------------------------------------------


c


README.md (line 5)
<https://reviews.apache.org/r/41700/#comment172168>

    reviewboard complains about "blanks at end of line", I agree... multiple of these throughout.



scripts/vagrant/application.conf (line 22)
<https://reviews.apache.org/r/41700/#comment172169>

    Typo: Wave



scripts/vagrant/application.conf (line 46)
<https://reviews.apache.org/r/41700/#comment172170>

    Typo: server



scripts/vagrant/setup-fedora.sh (line 21)
<https://reviews.apache.org/r/41700/#comment172171>

    are we sure we want to auto-upgrade between minor (.. well, major) Java versions without
cross-checking? I'd opt for pinning down a known-good version (for now), if random people
are supposed to be using this code.
    
    we do it on other platforms (same for mongodb)



scripts/vagrant/setup-fedora.sh (line 31)
<https://reviews.apache.org/r/41700/#comment172172>

    can we import the version number from somewhere?



scripts/vagrant/setup-ubuntu.sh (line 34)
<https://reviews.apache.org/r/41700/#comment172173>

    can we import the version number from somewhere?


change applies cleanly and meets at least my personal needs for maintainability and readability.
further comments opened as issues, but no blockers.

currently trying a "vagrant up" on Windows 10.

- Andreas Kotes


On Dez. 24, 2015, 4:19 vorm., Evan Hughes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41700/
> -----------------------------------------------------------
> 
> (Updated Dez. 24, 2015, 4:19 vorm.)
> 
> 
> Review request for wave, Ali Lown and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> Adds vagrant config for linux and windows vm's
> 
> 
> Diffs
> -----
> 
>   .gitignore b8ef753 
>   README.md 3be1780 
>   Vagrantfile PRE-CREATION 
>   release/artifact-sign.sh 004d5f0 
>   scripts/release/artifact-sign.sh PRE-CREATION 
>   scripts/vagrant/application.conf PRE-CREATION 
>   scripts/vagrant/setup-fedora.sh PRE-CREATION 
>   scripts/vagrant/setup-ubuntu.sh PRE-CREATION 
>   scripts/vagrant/setup-win-choco.cmd PRE-CREATION 
>   scripts/vagrant/setup-win.cmd PRE-CREATION 
>   wave/build.gradle ca39a6d 
> 
> Diff: https://reviews.apache.org/r/41700/diff/
> 
> 
> Testing
> -------
> 
> Can run server in all vm's (fedora, ubuntu, win 10)
> 
> 
> Thanks,
> 
> Evan Hughes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message