incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request 31837: Fix for caret issues in Chrome+Linux with periods and apostrophes
Date Tue, 21 Apr 2015 13:35:42 GMT


> On March 9, 2015, 6:15 a.m., Yuri Zelikov wrote:
> >
> 
> Vicente J. Ruiz Jurado wrote:
>     Any other comment? @akaplanov?
> 
> Andrew Kaplanov wrote:
>     I can't reproduce this situation on Ubuntu with Chrome and Firefox.
>     Try to input the same text in another application. Possibly the problem is not caused
by Wave.
> 
> Vicente J. Ruiz Jurado wrote:
>     It's strange that you cannot reproduce it. I have several users complaining about
this.
>     
>     I have just tested in Ubuntu:
>     - Chromium 41.0.2272.76, richt click, new window with new temporal profile
>     - I open: waveinabox.net
>     - Click: New Wave
>     - I type:
>     abc.abc.abc.
>     - What I get?
>     abcabcabc.|..
>     
>     Doing the same test in wiab.pro I get:
>     abc.abc.abc.|
>     that is the correct behaviour.
>     
>     the | is the caret
>     
>     I've tested using both English and Spanish keyboard layout.

I was able to reproduce this in RC8 on Chromium 39 in Linux yesterday.


- Ali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31837/#review75665
-----------------------------------------------------------


On March 9, 2015, 12:23 a.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31837/
> -----------------------------------------------------------
> 
> (Updated March 9, 2015, 12:23 a.m.)
> 
> 
> Review request for wave, Andrew Kaplanov, Pablo Ojanguren, and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> This patch fix a issue in Chrome+Linux with periods and apostrophes. For instance if
you type:
> 
> ...abc...
> 
> the result must be
> 
> ...abc...| 
> 
> (where | is the caret/cursor), but instead you get:
> 
> abc|......
> 
> and the same whith apostrophes:
> 
> abc|''''''
> 
> It seems that this issue is not present in wiab.pro so maybe is interesting the review
of akaplanov.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/common/util/SignalKeyLogic.java 5da169a 
> 
> Diff: https://reviews.apache.org/r/31837/diff/
> 
> 
> Testing
> -------
> 
> ant waveharness-superdev tested in FF and Chrome (Linux) and Chorme in Mac.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message