incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request 25034: FormButtonClicked event for Robot API ; From Element addition from robots
Date Tue, 07 Apr 2015 21:28:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25034/#review79258
-----------------------------------------------------------


Sorry it took so long, I am going to review this now.

- Yuri Zelikov


On Aug. 25, 2014, 8:04 p.m., Antonio Tenorio-Fornés wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25034/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 8:04 p.m.)
> 
> 
> Review request for wave and Pablo Ojanguren.
> 
> 
> Bugs: WAVE-418
>     https://issues.apache.org/jira/browse/WAVE-418
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> FormButtonClicked appears in Robot API but was not implemented.
> In addition, Form elements can now be added through Robot API.
> 
> 
> Diffs
> -----
> 
>   build.xml 83b20408e3038f2cb0f0ccc08eddac2ee6f801c1 
>   src/org/waveprotocol/box/server/robots/operations/DocumentModifyService.java 2a501c96f8f62712d7dbeabc01bff721f38d9cdd

>   src/org/waveprotocol/box/server/robots/passive/EventGenerator.java be70f0b0c627c371b7c556146b35be59df53c1a2

>   src/org/waveprotocol/wave/client/doodad/form/button/Button.java 7831cd9c07264d7cb3467bda9d1f9ab969beb36d

>   src/org/waveprotocol/wave/client/editor/Editors.java 0ff2538219c023778707ccd87978c30ab843e32c

> 
> Diff: https://reviews.apache.org/r/25034/diff/
> 
> 
> Testing
> -------
> 
> -    Add a gadget in a wave conversation.
> -    Invite a robot to the conversation which logs FormButtonClicked events (previously
registered) and adds a form button element. simple modification to https://gitorious.org/p2pvalue/waverobotbasicsample
> -    Verify that the robot has logged the expected event.
> 
> 
> Thanks,
> 
> Antonio Tenorio-Fornés
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message