incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request 31900: Fix for caret issues with IME in Chrome+Linux
Date Wed, 25 Mar 2015 13:52:18 GMT


> On Mar. 23, 2015, 10:28 p.m., Vicente J. Ruiz Jurado wrote:
> > Same here. Comments?

Unfortunatelly, I see that this patch doesn't solves all the issues with caret in chrome+linux.


I'll try to find an better patch (any help welcome).

PS: ant editor-superdev is very useful for this task.


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31900/#review77482
-----------------------------------------------------------


On Mar. 14, 2015, 5:50 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31900/
> -----------------------------------------------------------
> 
> (Updated Mar. 14, 2015, 5:50 p.m.)
> 
> 
> Review request for wave, Andrew Kaplanov, Pablo Ojanguren, and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> In Chrome+Linux using typingExtractor only for IME cause caret position errors in boundaries,
so as in Firefox we use typingExtractor always.
> 
> As a sample of the issue, if you type "más" in chrome+linux you get:
> 
> ms|á
> 
> instead of:
> 
> más|
> 
> (where | is the caret).
> 
> This was also fixed in wiab.pro so maybe Akaplanov proposes other approach.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/editor/event/EditorEventHandler.java 05a0e51 
> 
> Diff: https://reviews.apache.org/r/31900/diff/
> 
> 
> Testing
> -------
> 
> Some typing tests in waveharness
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message