incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Denis Konovalchik" <>
Subject Re: Review Request 25230: Text marked as deleted keeps the style properties of the source text.
Date Thu, 04 Sep 2014 12:28:44 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Сен. 4, 2014, 12:28 п.п.)

Review request for wave, Andrew Kaplanov and Yuri Zelikov.


I returned to the idea of Diff Revision 2 (using iterator on AnnotationInterval rather than
RangedAnnotation). Instead of location, map of annotations is passed into createDeleteElement()
Removed "TEXT" from names of AnnotationConstants.TEXT_STYLE_KEYS and AnnotationConstants.DELETED_TEXT_STYLE_KEYS.

Repository: wave


At present moment the text marked as deleted within blip is displayed with standard style,
and any formatting of it made before is lost. This patch is designed to display deleted text
with the same formatting as it had before deletion.
If it's necessary, instead of one span keeping deleted text with standard style several spans
are created, each of them has its own style attributes (color, fontFamily, fontSize, fontStyle
and fontWeight). Because attributes "backgroundColor" (light red) and "textDecoration" (strike
through) for any deleted text are defined by css, they are not copied from the source text

Diffs (updated)

  src/org/waveprotocol/wave/client/editor/content/ 30b4af2 
  src/org/waveprotocol/wave/client/editor/content/misc/ f0a68f8

  src/org/waveprotocol/wave/model/conversation/ 3fe9284 



Create blip with text and apply to it different formatting attributes (make some parts of
it italic, bold, some different font family, size and color). Then delete this text by another
user, and check that source formatting in deleted area is the same as it was before deletion.


Denis Konovalchik

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message