incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request 25021: Fixes Delta signature verification fail with wildcard certificates
Date Mon, 25 Aug 2014 12:36:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25021/#review51395
-----------------------------------------------------------

Ship it!


LGTM once you fix the trailing whitespace.

(I had been testing federation without setting up verification, so I hadn't spotted this issue).


src/org/waveprotocol/wave/crypto/WaveSignatureVerifier.java
<https://reviews.apache.org/r/25021/#comment89708>

    Could we lose these trailing spaces?


- Ali Lown


On Aug. 25, 2014, 11:42 a.m., Pablo Ojanguren wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25021/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 11:42 a.m.)
> 
> 
> Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Bugs: WAVE-416
>     https://issues.apache.org/jira/browse/WAVE-416
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> 
> In an federated environment, when a remote delta is received in A from host B, signature
verification fails if B cert is a wildcard certificate.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/crypto/WaveSignatureVerifier.java 0b4238ec982484450d34fb54aeb0dce2c901289e

> 
> Diff: https://reviews.apache.org/r/25021/diff/
> 
> 
> Testing
> -------
> 
> In our federation test environment both servers are in the same domain, so the problem
arose: federation-1.p2pvalue.eu and federation-2.p2pvalue.eu 
> After server patch was applied the federation works good.
> 
> 
> Thanks,
> 
> Pablo Ojanguren
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message