incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Kaplanov" <akapla...@gmail.com>
Subject Re: Review Request 23166: Improving of profiling code.
Date Sun, 06 Jul 2014 09:46:44 GMT


> On June 30, 2014, 4:43 p.m., Yuri Zelikov wrote:
> > Thanks
> > Looks like the file src/org/waveprotocol/box/webclient/stat/SingleThreadedRequestScope.java
is missing.
> 
> Andrew Kaplanov wrote:
>     Please execute this before patch:
>     git mv src/org/waveprotocol/box/stat/SingleThreadedRequestScope.java src/org/waveprotocol/box/webclient/stat/SingleThreadedRequestScope.java
>     Command "git diff" was not detected rename, maybe --find-renames option required
in such cases.

Something wrong? 
Did it work?


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23166/#review46990
-----------------------------------------------------------


On June 30, 2014, 12:38 p.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23166/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 12:38 p.m.)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> SingleThreadedRequestScope is not default scope now, Timing begins with null scope initially.
> Tests does not run profiling now.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/executor/RequestScopeExecutor.java 9b2c935 
>   src/org/waveprotocol/box/server/executor/ScheduledRequestScopeExecutor.java 824a7d5

>   src/org/waveprotocol/box/server/rpc/WebSocketChannel.java 7b55dac 
>   src/org/waveprotocol/box/server/stat/MultiThreadedRequestScope.java b473f6a 
>   src/org/waveprotocol/box/server/stat/RequestScopeFilter.java 021739b 
>   src/org/waveprotocol/box/stat/AsyncCallContext.java 2f487b5 
>   src/org/waveprotocol/box/stat/StatRecorder.java bb85ee1 
>   src/org/waveprotocol/box/stat/Timing.java 98273b7 
>   src/org/waveprotocol/box/webclient/client/WebClient.java 1c377fb 
>   src/org/waveprotocol/box/webclient/stat/SingleThreadedRequestScope.java 6a113af 
>   src/org/waveprotocol/wave/client/scheduler/TaskInfo.java 420807e 
>   src/org/waveprotocol/wave/client/wavepanel/event/FocusManager.java 6704ae1 
> 
> Diff: https://reviews.apache.org/r/23166/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message