incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pablo Ojanguren" <pablo...@gmail.com>
Subject Re: Review Request 17943: Inbox filter by date range
Date Wed, 16 Apr 2014 07:54:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17943/
-----------------------------------------------------------

(Updated April 16, 2014, 7:54 a.m.)


Review request for wave.


Changes
-------

Code clean up: removed non useful comments and fix license header.

Dialog uses rigt date format according to the client locale


Bugs: WAVE-408
    https://issues.apache.org/jira/browse/WAVE-408


Repository: wave


Description
-------

- Server part: added new operators to the search query string to indicate a date range to
filter a wave search.

               From:yyyyMMdd Select wavelets with a later date value.

               To:yyyyMMdd Select wavelets with an earlier or equal date value.

               Usedate:[createdate|lastmoddate]
               Date field for filtering.


- Client part: added a dialog box to select dates, participants and creator. It's opened clicking
a new buttom in the search panel.


Diffs (updated)
-----

  src/org/waveprotocol/box/server/waveserver/QueryHelper.java c108e5bf6ec31d69f229ddf0408f0ea405ed14bb

  src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java 3c698164fa509b20d753934ed0d24ccd5595cbc1

  src/org/waveprotocol/box/server/waveserver/TokenQueryType.java 654635041067339a09e695910778ad1444e43ce5

  src/org/waveprotocol/box/webclient/search/Search.css d0b0a94661d350b240f6bca37468cc84fcb98739

  src/org/waveprotocol/box/webclient/search/SearchFilterDialog.css PRE-CREATION 
  src/org/waveprotocol/box/webclient/search/SearchFilterDialogView.java PRE-CREATION 
  src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.java PRE-CREATION 
  src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.ui.xml PRE-CREATION 
  src/org/waveprotocol/box/webclient/search/SearchPanelResourceLoader.java 178470832ba0246ed9c34892af615fb3d1c85d30

  src/org/waveprotocol/box/webclient/search/SearchWidget.java 076aa4b571dedf86e93c190802c81359cba847b5

  src/org/waveprotocol/box/webclient/search/SearchWidget.ui.xml f929f709d618cf19d95a99a1d3c5961d984dc6ac

  src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages.java 490b8397c2532b243a30e7277cf634c05fc8c7e6


Diff: https://reviews.apache.org/r/17943/diff/


Testing
-------

Manual test: tested different ranges of dates ensuring that only right waves were selected.


Thanks,

Pablo Ojanguren


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message