incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request 19116: Profile fetcher selection and new initials avatars
Date Mon, 24 Mar 2014 12:19:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19116/
-----------------------------------------------------------

(Updated March 24, 2014, 12:19 p.m.)


Review request for wave, Ali Lown and Yuri Zelikov.


Changes
-------

Fixed build and classpath with correct jar destination (codegen vs runtime).


Repository: wave


Description
-------

This patch add a new configuration option to select between different profile fetchers:
- the current one (based in Gravatar)
- a new one called "Initials" inspired in the defaults avatars of Android Gmail App, see,
for instance:
http://www.androidcentral.com/sites/androidcentral.com/files/postimages/444537/new-gmail-2.png
so you can choose what profile fetcher to use (gravatar or initials) in your wave server.

The goal is to identify the participant with its initial (and random colors) and also to avoid
the use of external avatar services if you don't want to:
http://meta.stackoverflow.com/questions/44717/is-gravatar-a-privacy-risk

It uses a new library I'm working on, that also will allow to composite several avatars (if
we are interested in use it in the future for mobile version, etc):
https://gitorious.org/kune/gwt-initials-avatars/

A screeshoot:
http://homes.ourproject.org/~vjrj/otros/initials-in-wave.png
and some more examples of the lib:
http://homes.ourproject.org/~vjrj/otros/initials-avatars.png


Diffs (updated)
-----

  .classpath 2b1822f 
  build.xml 0681b16 
  server-config.xml 1f71757 
  server.config.example 795203b 
  src/org/waveprotocol/box/server/CoreSettings.java e61f688 
  src/org/waveprotocol/box/server/ServerMain.java 3e885cb 
  src/org/waveprotocol/box/server/robots/ProfileFetcherModule.java PRE-CREATION 
  src/org/waveprotocol/box/server/robots/RobotApiModule.java e3ede28 
  src/org/waveprotocol/box/server/robots/operations/InitialsProfilesFetcher.java PRE-CREATION


Diff: https://reviews.apache.org/r/19116/diff/


Testing
-------

I've tested the server with the two profile fetchers.


Thanks,

Vicente J. Ruiz Jurado


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message