incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request 19116: Profile fecher selection and new initials avatars
Date Wed, 12 Mar 2014 17:33:51 GMT


> On March 12, 2014, 4:50 p.m., Ali Lown wrote:
> > Does this really need an external library?
> > 
> > The actual implementation here seems fine.

In kune I prefer to do these kind of libs so people can use it, improve it, fork it, etc.


For instance, our xmpp chat libs:
https://github.com/EmiteGWT/
it's more work but it's more "correct" from a FLOSS point of view, I think.

Also the GWT client lib have other implementations, that I'm not sure that we'll use in wave
(lets see).


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19116/#review36930
-----------------------------------------------------------


On March 12, 2014, 1:27 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19116/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 1:27 p.m.)
> 
> 
> Review request for wave, Ali Lown and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> This patch add a new configuration option to select between different profile fetchers:
> - the current one (based in Gravatar)
> - a new one called "Initials" inspired in the defaults avatars of Android Gmail App,
see, for instance:
> http://www.androidcentral.com/sites/androidcentral.com/files/postimages/444537/new-gmail-2.png
> so you can choose what profile fetcher to use (gravatar or initials) in your wave server.
> 
> The goal is to identify the participant with its initial (and random colors) and also
to avoid the use of external avatar services if you don't want to:
> http://meta.stackoverflow.com/questions/44717/is-gravatar-a-privacy-risk
> 
> It uses a new library I'm working on, that also will allow to composite several avatars
(if we are interested in use it in the future for mobile version, etc):
> https://gitorious.org/kune/gwt-initials-avatars/
> 
> A screeshoot:
> http://homes.ourproject.org/~vjrj/otros/initials-in-wave.png
> and some more examples of the lib:
> http://homes.ourproject.org/~vjrj/otros/initials-avatars.png
> 
> 
> Diffs
> -----
> 
>   .classpath 2b1822f 
>   build.xml 0a1b23c 
>   server-config.xml 1f71757 
>   server.config.example 795203b 
>   src/org/waveprotocol/box/server/CoreSettings.java e61f688 
>   src/org/waveprotocol/box/server/ServerMain.java 3e885cb 
>   src/org/waveprotocol/box/server/robots/ProfileFetcherModule.java PRE-CREATION 
>   src/org/waveprotocol/box/server/robots/RobotApiModule.java e3ede28 
>   src/org/waveprotocol/box/server/robots/operations/InitialsProfilesFetcher.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/19116/diff/
> 
> 
> Testing
> -------
> 
> I've tested the server with the two profile fetchers.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message