incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yuri Z <vega...@gmail.com>
Subject Re: Code reviews app
Date Wed, 15 Jan 2014 20:26:21 GMT
Judging by the comments in the issue, it doesn't look like Gerrit is a real
option. Anyway, I left a comment there with the question.


On Mon, Jan 13, 2014 at 6:33 PM, Ryan Hill <rch@zndx.org> wrote:

> +1 for Gerrit
>
>
> On Mon, Jan 13, 2014 at 3:35 AM, Thomas Broyer <t.broyer@gmail.com> wrote:
>
> > On Sun, Jan 12, 2014 at 5:14 PM, Yuri Z <vega113@gmail.com> wrote:
> >
> > > Hi
> > > Until now we used ReviewBoard for code reviews. It's a powerful app and
> > it
> > > served us well, but it seems like there are a few pros and cons.
> > > As we recently moved to Git, we have a new option - we can use the
> GitHub
> > > forks - https://github.com/apache/incubator-wave
> > > What you think?
> > >
> >
> > I learned to hate ReviewBoard, but would using GitHub PRs be an accepted
> > alternative at the Apache Foundation?
> >
> > GitHub PRs mean that any contributor is required to have a GitHub
> account.
> > Also, given that the wave repo at GitHub is a mirror, I'm not sure how
> > merging would work (re. closing the PR for instance — OK, definitely
> better
> > than with ReviewBoard, but still more involved than just pushing a
> button).
> >
> > A better alternative to ReviewBoard at the ASF is Gerrit:
> > https://issues.apache.org/jira/browse/INFRA-2205
> >
> > --
> > Thomas Broyer
> > /tɔ.ma.bʁwa.je/ <http://xn--nna.ma.xn--bwa-xxb.je/> <
> http://xn--nna.ma.xn--bwa-xxb.je/> <
> > http://xn--nna.ma.xn--bwa-xxb.je/>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message