incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Hegarty <heg...@gmail.com>
Subject Re: Review Request 16698: MongoDB implementation for the delta store
Date Tue, 14 Jan 2014 08:44:07 GMT
Hi Yuri,
I was wondering if you had a chance to test this diff and run the mongodb
unit tests?

I noticed that the Mongodb unit tests had a fundamental flaw that caused
the database to hang around, they were actually using the 'fedone' DB and
not the unit test defined database name, I also noticed that one of the
existing tests had a bug where it relied on the DB results from the
previous execution which I corrected.

I also broke the account store, signer store and attachment store into
separate files for better readability.

Regards
Ben


On Wed, Jan 8, 2014 at 10:20 PM, <hegsie@gmail.com> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16698/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 10:20 p.m.)
>
>
> Review request for wave.
>
>
> Changes
> -------
>
> Removed the commented lines
>
>
> Repository: wave
>
>
> Description
> -------
>
> Implements DeltaStore and DeltaAccess
>
>
> Diffs (updated)
> -----
>
>   .classpath b4632d5
>   build.xml 70db95c
>   src/org/waveprotocol/box/server/persistence/PersistenceModule.java
> a430570
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbAccountStore.java
> PRE-CREATION
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbAttachmentStore.java
> PRE-CREATION
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaCollection.java
> PRE-CREATION
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaStore.java
> PRE-CREATION
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbHashedVersion.java
> PRE-CREATION
>   src/org/waveprotocol/box/server/persistence/mongodb/MongoDbProvider.java
> 6f5170f
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbSignerInfoStore.java
> PRE-CREATION
>   src/org/waveprotocol/box/server/persistence/mongodb/MongoDbStore.java
> c6228b3
>   src/org/waveprotocol/box/server/persistence/mongodb/MongoDbWaveId.java
> PRE-CREATION
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbWaveletDeltaRecord.java
> PRE-CREATION
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbWaveletIdUtils.java
> PRE-CREATION
>
> src/org/waveprotocol/box/server/persistence/mongodb/MongoDbWaveletName.java
> PRE-CREATION
>
> test/org/waveprotocol/box/server/persistence/mongodb/AccountStoreTest.java
> df79f79
>
> test/org/waveprotocol/box/server/persistence/mongodb/AttachmentStoreTest.java
> 46dd70b
>
> test/org/waveprotocol/box/server/persistence/mongodb/CertPathStoreTest.java
> 62bcd74
>   test/org/waveprotocol/box/server/persistence/mongodb/DeltaStoreTest.java
> PRE-CREATION
>   third_party/runtime/mongo-driver/LICENSE.txt 4a67574
>   third_party/runtime/mongo-driver/README.google b5aaa70
>   third_party/runtime/mongo-driver/mongo-2.1.jar
> 0936004ad2dba281e67f244b127cbfe9d72fa426
>   third_party/runtime/mongo-driver/mongo-java-driver-2.11.2.jar
> PRE-CREATION
>   third_party/runtime/mongo-driver/mongo-java-driver-r2.1-0-src.zip
> 41f4a34251228fcccf2ea3e11e1ea5d92ae73a22
>   third_party/runtime/morphia/morphia-0.105.jar PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16698/diff/
>
>
> Testing
> -------
>
> Unit Tests and Manual execution of the wave server.
>
>
> Thanks,
>
> hegsie
>
>


-- 
Regards
Ben

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message