incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request 17373: Removes support of locales from WebClientDev.
Date Mon, 27 Jan 2014 09:42:08 GMT


> On Jan. 27, 2014, 3:50 a.m., Ali Lown wrote:
> > I don't feel that removing all languages from the -dev flavour is really correct.
(Since it defeats the ability to develop against language features (e.g. changes to the language
handling).
> > 
> > Perhaps just the removal of the russian flavour in dev, so that english is the only
available option (which would halve the amount of time spent on permutation compilation) [During
development builds, I just don't find that permutations are the slow part. {And on my system,
this won't have any effect due to having enough cores to run all dev permutations simultaneously!}].

I agree with Ali, but if we let only English we'll no detect other issues as utf8 problems,
etc, and this is why Russian is there.

Anyway I recommend to use gwt dev mode for development:
http://www.waveprotocol.org/code/client-development-environment-set-up

and only compile to deploy.


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17373/#review32811
-----------------------------------------------------------


On Jan. 26, 2014, 8:54 p.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17373/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2014, 8:54 p.m.)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> Supporting of locales on compile-gwt-dev requires many time to compile what make development
too slow.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/WebClientDev.gwt.xml da32dd7 
> 
> Diff: https://reviews.apache.org/r/17373/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message