incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Kaplanov" <akapla...@gmail.com>
Subject Re: Review Request 17143: Improves settings of Jetty
Date Tue, 21 Jan 2014 21:12:46 GMT


> On Jan. 21, 2014, 9:02 p.m., Yuri Zelikov wrote:
> > build.xml, line 551
> > <https://reviews.apache.org/r/17143/diff/2/?file=433621#file433621line551>
> >
> >     Why remove this?

It is my own code from previous patch.
It was taken from Wiab.pro and excess for Apache Wiab.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17143/#review32420
-----------------------------------------------------------


On Jan. 21, 2014, 8:50 p.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17143/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 8:50 p.m.)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> - Appended session_cookie_max_age parameter to server.config.
> 
> - Jetty does not allow to set infinite idle timeout to websocket session. It has default
timeout 300000 ms.
>   On attempt to assign 0, or -1 it says "IdleTimeout must be a postive value larger than
0".
>   So, zero value, assigned to websocket_max_idle_time Wiab config variable, replaced
to Integer.MAX_VALUE on call to Jetty.
> 
> 
> Diffs
> -----
> 
>   build.xml 00d1f23 
>   server-config.xml 16b4f68 
>   server.config.example 309a0df 
>   src/org/waveprotocol/box/server/CoreSettings.java 5beaf65 
>   src/org/waveprotocol/box/server/ServerModule.java 4dddaa1 
>   src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 0809e9b 
> 
> Diff: https://reviews.apache.org/r/17143/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message