incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pablo Ojanguren" <pablo...@gmail.com>
Subject Re: Review Request 16751: MongoDB store for deltas
Date Mon, 13 Jan 2014 10:53:58 GMT


> On Jan. 12, 2014, 7:35 p.m., Andrew Kaplanov wrote:
> > src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaCollection.java,
line 81
> > <https://reviews.apache.org/r/16751/diff/1/?file=419416#file419416line81>
> >
> >     This query can be created only one time.

Methods calling to getWaveletDBQuery() add new values to this query object, so it changes
(see lines 143, 164, 181).


> On Jan. 12, 2014, 7:35 p.m., Andrew Kaplanov wrote:
> > src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaCollection.java,
line 115
> > <https://reviews.apache.org/r/16751/diff/1/?file=419416#file419416line115>
> >
> >     Double cast?

The .get(...) method returns type Object so it's necessary to cast it to DBObject. Double
cast is neede because I perform two nested calls to get(...). Is there a more proper way to
write it?


> On Jan. 12, 2014, 7:35 p.m., Andrew Kaplanov wrote:
> > src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaStoreUtil.java,
line 240
> > <https://reviews.apache.org/r/16751/diff/1/?file=419418#file419418line240>
> >
> >     TODO -> TODO:

TODO No needed anymore, I was concern about .size() performance but it only matters for mongo
cursors but that is a list.


- Pablo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16751/#review31592
-----------------------------------------------------------


On Jan. 9, 2014, 12:56 p.m., Pablo Ojanguren wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16751/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 12:56 p.m.)
> 
> 
> Review request for wave.
> 
> 
> Bugs: WAVE-399
>     https://issues.apache.org/jira/browse/WAVE-399
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> Implementation of a MongoDB store for deltas via DeltaAccess and DeltaStore interfaces.

> All methods call DB avoiding memory structures.
> Data model design is: a collection for storing deltas, a document per delta:
> 
> { "_id" : { "$oid" : "52ce91a044ae038d55248a85"} , 
>   "waveid" : "local.net/w+-WphE1C2YjA" , 
>   "waveletid" : "local.net!conv+root" , 
>   "appliedatversion" : { "version" : 84 , "historyhash" : { "$binary" : "4j3ZlQ35ss5OJUudS+0aH/+On1M="
, "$type" : 0}} , "applied" : { "$binary" : "..." , "$type" : 0} ,รง
>   "transformed" : { "author" : { "address" : "root@local.net"} , 
>                     "resultingversion" : { "version" : 85 , "historyhash" : { "$binary"
: "DmwTp4QLsGXL5dm9yPs9Pd9dMOo=" , "$type" : 0}} , 
>                     "applicationtimestamp" : 1389269408793 , 
>                     "appliedatversion" : 84 , 
>                     "ops" : 
>                           [ { "type" : "WaveletBlipOperation" , 
>                               "blipid" : "b+-WphE1C2YjC" , 
>                               "blipop" : { "contentop" : { "bytes" : { "$binary" : "CgIoDwoDEgFoCgIoAQ=="
, "$type" : 0}}}}
>                           ]}}
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/persistence/PersistenceModule.java a430570 
>   src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaCollection.java PRE-CREATION

>   src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaStore.java PRE-CREATION

>   src/org/waveprotocol/box/server/persistence/mongodb/MongoDbDeltaStoreUtil.java PRE-CREATION

>   src/org/waveprotocol/box/server/persistence/mongodb/MongoDbProvider.java 6f5170f 
>   third_party/runtime/mongo-driver/mongo-2.1.jar 0936004 
>   third_party/runtime/mongo-driver/mongo-java-driver-2.11.2.jar PRE-CREATION 
>   third_party/runtime/mongo-driver/mongo-java-driver-r2.1-0-src.zip 41f4a34 
> 
> Diff: https://reviews.apache.org/r/16751/diff/
> 
> 
> Testing
> -------
> 
> Functional test only: three users editing concurrently same and differents waves from
differentes clients.
> 
> 
> Thanks,
> 
> Pablo Ojanguren
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message