incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request 16694: Refactors SimpleSearchProvider
Date Fri, 10 Jan 2014 01:45:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16694/#review31503
-----------------------------------------------------------

Ship it!


LGTM.

- Ali Lown


On Jan. 7, 2014, 7:32 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16694/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2014, 7:32 p.m.)
> 
> 
> Review request for wave, Ali Lown and Frank R..
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> Refactors SimpleSearchProvider - moves common methods to base abstract class.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/waveserver/AbstractSearchProviderImpl.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java 9469743 
> 
> Diff: https://reviews.apache.org/r/16694/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message