incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Kaplanov" <akapla...@gmail.com>
Subject Re: Review Request 16639: Update of Guava, Jetty and Protobuf third party libraries
Date Wed, 08 Jan 2014 20:46:49 GMT


> On Jan. 7, 2014, 6:54 p.m., Vicente J. Ruiz Jurado wrote:
> > Great job, as usual Andrew. 
> > 
> > Can you put somewhere a tar with the new jars?
> > 
> > I'm with Frank, will we great to have more info about this review...
> > 
> > Looking in your new websocket code, I don't know if it's better to update socket-io-java
to jetty 9, or to play with things like:
> > 
> > https://github.com/Atmosphere/atmosphere/wiki/Writing-WebSocket-Sub-Protocol
> >
> 
> Andrew Kaplanov wrote:
>     Thanks.
>     I don't see reason to include Atmosphere Framework to Wiab. WebSocket implementation
in Jetty is simple and functional.
>     Perhaps you thought something in my implementation ugly, I'm ready to take notes.
> 
> Vicente J. Ruiz Jurado wrote:
>     No, no, nothing ugly. But I was just asking myself if it's more interesting to don't
update that old version of socket-io-java or move to other modern alternative (like atmosphere).
>     
>     In the client side libraries like socket-io and atmosphere have fallback to other
alternative connectors if websocket is not available in the client side or is not functional
(because is filtered by proxies). 
>     
>     In the server side, it can be interesting to make wiab independent of the servlet
container.

Ok, looks like you're right. I will study in more detail Atmosphere Framework, this is an
interesting project.
But Atmosphere Framework also does not support Jetty 9 now: https://github.com/Atmosphere/atmosphere/wiki/Supported-WebServers-and-Browsers.
Although unlike Socket.IO-Java it is a living project and probably soon will support.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16639/#review31303
-----------------------------------------------------------


On Jan. 8, 2014, 6:40 p.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16639/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 6:40 p.m.)
> 
> 
> Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> I had to disable SocketIO servlet, because library, that support it - https://github.com/vjrj/Socket.IO-Java
- still not been updated to support Jetty 9.
> 
> 
> Diffs
> -----
> 
>   build.xml 70db95c 
>   src/com/google/wave/api/robot/HttpRobotConnection.java 75ac450 
>   src/org/waveprotocol/box/common/comms/waveclient-rpc.proto b5fae29 
>   src/org/waveprotocol/box/server/ServerMain.java b50454d 
>   src/org/waveprotocol/box/server/ServerModule.java 71917c9 
>   src/org/waveprotocol/box/server/frontend/WaveViewSubscription.java e670dd9 
>   src/org/waveprotocol/box/server/frontend/WaveletInfo.java faf2fb3 
>   src/org/waveprotocol/box/server/persistence/file/FileDeltaStore.java c2b9f11 
>   src/org/waveprotocol/box/server/persistence/protos/delta-store.proto 4f08148 
>   src/org/waveprotocol/box/server/robots/agent/passwd/PasswordRobot.java 460f724 
>   src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java feccb7d 
>   src/org/waveprotocol/box/server/robots/dataapi/DataApiTokenContainer.java 901b53c 
>   src/org/waveprotocol/box/server/rpc/AbstractWaveSocketIOServlet.java 0d93b6a 
>   src/org/waveprotocol/box/server/rpc/GadgetProviderServlet.java 1a10d72 
>   src/org/waveprotocol/box/server/rpc/ProtoCallback.java 24bd21f 
>   src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 7f65672 
>   src/org/waveprotocol/box/server/rpc/WebSocketChannelImpl.java PRE-CREATION 
>   src/org/waveprotocol/box/server/rpc/WebSocketClientChannel.java 3265274 
>   src/org/waveprotocol/box/server/rpc/WebSocketClientRpcChannel.java b067c13 
>   src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java 89ab899 
>   src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java 04821f5

>   src/org/waveprotocol/box/server/waveserver/LucenePerUserWaveViewHandlerImpl.java d61e2e0

>   src/org/waveprotocol/box/server/waveserver/MemoryPerUserWaveViewHandlerImpl.java 7fa8408

>   src/org/waveprotocol/box/server/waveserver/Wave.java b28069e 
>   src/org/waveprotocol/box/server/waveserver/WaveMap.java a5616d2 
>   src/org/waveprotocol/box/server/waveserver/WaveServerModule.java d706153 
>   src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 92b7b93

>   src/org/waveprotocol/examples/robots/echoey/Echoey.java c73fe5e 
>   src/org/waveprotocol/wave/federation/xmpp/RemoteDisco.java 999c8a7 
>   src/org/waveprotocol/wave/federation/xmpp/XmppDisco.java 5745f91 
>   src/org/waveprotocol/wave/federation/xmpp/XmppFederationHost.java a666d53 
>   test/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServletTest.java d625c60

>   test/org/waveprotocol/box/server/rpc/RpcTest.java 5a0b07c 
>   test/org/waveprotocol/box/server/rpc/WebSocketChannelTest.java e5ab7b9 
>   test/org/waveprotocol/wave/federation/xmpp/MockDisco.java 28f25c7 
>   test/org/waveprotocol/wave/federation/xmpp/XmppDiscoTest.java aad419d 
>   test/org/waveprotocol/wave/federation/xmpp/XmppFederationHostForDomainTest.java c47d01f

>   third_party/runtime/gson/LICENSE PRE-CREATION 
>   third_party/runtime/gson/README.google 6136ac4 
>   third_party/runtime/gson/gson-1.4.jar b9c33d0 
>   third_party/runtime/gson/gson-2.2.4.jar PRE-CREATION 
>   third_party/runtime/guava/README.google 1bcc427 
>   third_party/runtime/guava/guava-15.0.jar PRE-CREATION 
>   third_party/runtime/guava/guava-gwt-15.0.jar PRE-CREATION 
>   third_party/runtime/guava/guava-r09-gwt.jar 5f130e5 
>   third_party/runtime/guava/guava-r09.jar f8da8b1 
>   third_party/runtime/jetty/README.google 50e1266 
>   third_party/runtime/jetty/jetty-annotations-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-client-8.1.1.v20120215.jar c0dbff1 
>   third_party/runtime/jetty/jetty-client-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-continuation-8.1.1.v20120215.jar 321153c 
>   third_party/runtime/jetty/jetty-continuation-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-http-8.1.1.v20120215.jar 3a2b3f0 
>   third_party/runtime/jetty/jetty-http-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-io-8.1.1.v20120215.jar d9f67c2 
>   third_party/runtime/jetty/jetty-io-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-proxy-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-security-8.1.1.v20120215.jar f75dbd1 
>   third_party/runtime/jetty/jetty-security-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-server-8.1.1.v20120215.jar 0a313af 
>   third_party/runtime/jetty/jetty-server-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-servlet-8.1.1.v20120215.jar aec7b8f 
>   third_party/runtime/jetty/jetty-servlet-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-servlets-8.1.1.v20120215.jar 9bb787e 
>   third_party/runtime/jetty/jetty-servlets-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-util-8.1.1.v20120215.jar 096f6cf 
>   third_party/runtime/jetty/jetty-util-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-webapp-8.1.1.v20120215.jar 0c8aa4a 
>   third_party/runtime/jetty/jetty-webapp-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-websocket-8.1.1.v20120215.jar b398c79 
>   third_party/runtime/jetty/jetty-xml-8.1.1.v20120215.jar 9df8fbd 
>   third_party/runtime/jetty/jetty-xml-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/servlet-api-3.0.jar b135409 
>   third_party/runtime/jetty/servlet-api-3.1.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-api-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-client-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-common-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-server-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-servlet-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/protobuf/README.google aa7c8c2 
>   third_party/runtime/protobuf/protobuf-2.3.0-src.jar ab81e5e 
>   third_party/runtime/protobuf/protobuf-java-2.3.0.jar f78b32b 
>   third_party/runtime/protobuf/protobuf-java-2.5.0.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16639/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message