incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request 16639: Update of Guava, Jetty and Protobuf third party libraries
Date Mon, 06 Jan 2014 11:20:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16639/#review31227
-----------------------------------------------------------


Hi Andrew
Can you maybe upload the patch without the generated protobuffs? I ll  generate them by myself.
The only issue is that the new generated sources don't have license header...

- Yuri Zelikov


On Jan. 6, 2014, 10:39 a.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16639/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 10:39 a.m.)
> 
> 
> Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> I had to disable SocketIO servlet, because library, that support it - https://github.com/vjrj/Socket.IO-Java
- still not been updated to support Jetty 9.
> 
> 
> Diffs
> -----
> 
>   build.xml 70db95c 
>   proto_src/org/waveprotocol/box/attachment/AttachmentProto.java 746af7c 
>   proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java 3806e5b 
>   proto_src/org/waveprotocol/box/profile/ProfilesProto.java c17525b 
>   proto_src/org/waveprotocol/box/search/SearchProto.java 5dbd1f1 
>   proto_src/org/waveprotocol/box/server/persistence/protos/ProtoAccountStoreData.java
124c912 
>   proto_src/org/waveprotocol/box/server/persistence/protos/ProtoDeltaStoreData.java d0922ef

>   proto_src/org/waveprotocol/box/server/rpc/Rpc.java af61e78 
>   proto_src/org/waveprotocol/protobuf/Extensions.java 93d56d6 
>   proto_src/org/waveprotocol/wave/concurrencycontrol/ClientServer.java 11d5dbc 
>   proto_src/org/waveprotocol/wave/diff/Diff.java ea85215 
>   proto_src/org/waveprotocol/wave/federation/FederationErrorProto.java e38fc2e 
>   proto_src/org/waveprotocol/wave/federation/Proto.java 814ac6f 
>   src/com/google/wave/api/robot/HttpRobotConnection.java 75ac450 
>   src/org/waveprotocol/box/common/comms/waveclient-rpc.proto b5fae29 
>   src/org/waveprotocol/box/server/ServerMain.java b50454d 
>   src/org/waveprotocol/box/server/ServerModule.java 71917c9 
>   src/org/waveprotocol/box/server/frontend/WaveViewSubscription.java e670dd9 
>   src/org/waveprotocol/box/server/frontend/WaveletInfo.java faf2fb3 
>   src/org/waveprotocol/box/server/persistence/file/FileDeltaStore.java c2b9f11 
>   src/org/waveprotocol/box/server/persistence/protos/delta-store.proto 4f08148 
>   src/org/waveprotocol/box/server/robots/agent/passwd/PasswordRobot.java 460f724 
>   src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java feccb7d 
>   src/org/waveprotocol/box/server/robots/dataapi/DataApiTokenContainer.java 901b53c 
>   src/org/waveprotocol/box/server/rpc/AbstractWaveSocketIOServlet.java 0d93b6a 
>   src/org/waveprotocol/box/server/rpc/GadgetProviderServlet.java 1a10d72 
>   src/org/waveprotocol/box/server/rpc/ProtoCallback.java 24bd21f 
>   src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 7f65672 
>   src/org/waveprotocol/box/server/rpc/WebSocketChannelImpl.java PRE-CREATION 
>   src/org/waveprotocol/box/server/rpc/WebSocketClientChannel.java 3265274 
>   src/org/waveprotocol/box/server/rpc/WebSocketClientRpcChannel.java b067c13 
>   src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java 89ab899 
>   src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java 04821f5

>   src/org/waveprotocol/box/server/waveserver/LucenePerUserWaveViewHandlerImpl.java d61e2e0

>   src/org/waveprotocol/box/server/waveserver/MemoryPerUserWaveViewHandlerImpl.java 7fa8408

>   src/org/waveprotocol/box/server/waveserver/Wave.java b28069e 
>   src/org/waveprotocol/box/server/waveserver/WaveMap.java a5616d2 
>   src/org/waveprotocol/box/server/waveserver/WaveServerModule.java d706153 
>   src/org/waveprotocol/box/server/waveserver/WaveletNotificationDispatcher.java 92b7b93

>   src/org/waveprotocol/examples/robots/echoey/Echoey.java c73fe5e 
>   src/org/waveprotocol/wave/federation/xmpp/RemoteDisco.java 999c8a7 
>   src/org/waveprotocol/wave/federation/xmpp/XmppDisco.java 5745f91 
>   src/org/waveprotocol/wave/federation/xmpp/XmppFederationHost.java a666d53 
>   test/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServletTest.java d625c60

>   test/org/waveprotocol/box/server/rpc/RpcTest.java 5a0b07c 
>   test/org/waveprotocol/box/server/rpc/WebSocketChannelTest.java e5ab7b9 
>   test/org/waveprotocol/wave/federation/xmpp/MockDisco.java 28f25c7 
>   test/org/waveprotocol/wave/federation/xmpp/XmppDiscoTest.java aad419d 
>   test/org/waveprotocol/wave/federation/xmpp/XmppFederationHostForDomainTest.java c47d01f

>   third_party/runtime/gson/LICENSE PRE-CREATION 
>   third_party/runtime/gson/README.google 6136ac4 
>   third_party/runtime/gson/gson-1.4.jar b9c33d0390790ad6ef9549e16e9349f0f7fffca7 
>   third_party/runtime/gson/gson-2.2.4.jar PRE-CREATION 
>   third_party/runtime/guava/README.google 1bcc427 
>   third_party/runtime/guava/guava-15.0.jar PRE-CREATION 
>   third_party/runtime/guava/guava-gwt-15.0.jar PRE-CREATION 
>   third_party/runtime/guava/guava-r09-gwt.jar 5f130e5fb6cbdea46fc444b1e100c7e2a790c3cb

>   third_party/runtime/guava/guava-r09.jar f8da8b1c1e81d583dc48d875fd23229f7271e132 
>   third_party/runtime/jetty/README.google 50e1266 
>   third_party/runtime/jetty/jetty-annotations-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-client-8.1.1.v20120215.jar c0dbff16b1d2200e8eb251dc3ea7cc3686026afd

>   third_party/runtime/jetty/jetty-client-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-continuation-8.1.1.v20120215.jar 321153c4eaa3b6799abcd7a282ad335d2e5770a4

>   third_party/runtime/jetty/jetty-continuation-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-http-8.1.1.v20120215.jar 3a2b3f0cb4a84e9ed6289071c15f5be696a5f733

>   third_party/runtime/jetty/jetty-http-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-io-8.1.1.v20120215.jar d9f67c24e45d29325b836793e7e73ad6e0751dfa

>   third_party/runtime/jetty/jetty-io-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-proxy-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-security-8.1.1.v20120215.jar f75dbd1afbfc267031ac1d52fbb30274aa80293f

>   third_party/runtime/jetty/jetty-security-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-server-8.1.1.v20120215.jar 0a313af27ee278a0e054d47225ceff2ad839a907

>   third_party/runtime/jetty/jetty-server-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-servlet-8.1.1.v20120215.jar aec7b8f95ab733336a0072999e800d8aa00b6868

>   third_party/runtime/jetty/jetty-servlet-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-servlets-8.1.1.v20120215.jar 9bb787ea5b673d78d88795a75d09e6c3710b820b

>   third_party/runtime/jetty/jetty-servlets-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-util-8.1.1.v20120215.jar 096f6cf92bd5b3827d904899c5bae0994919aef5

>   third_party/runtime/jetty/jetty-util-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-webapp-8.1.1.v20120215.jar 0c8aa4af4cb1cf8eeb224436703c170ac000f2cc

>   third_party/runtime/jetty/jetty-webapp-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/jetty-websocket-8.1.1.v20120215.jar b398c79ae8428d557962d6c8d844833200abcaab

>   third_party/runtime/jetty/jetty-xml-8.1.1.v20120215.jar 9df8fbdf339bb009af06ee457b763e2019245d49

>   third_party/runtime/jetty/jetty-xml-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/servlet-api-3.0.jar b135409682ee2173ee74cc9e9b00469d7fa0a27e

>   third_party/runtime/jetty/servlet-api-3.1.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-api-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-client-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-common-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-server-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/jetty/websocket-servlet-9.1.0.v20131115.jar PRE-CREATION 
>   third_party/runtime/protobuf/README.google aa7c8c2 
>   third_party/runtime/protobuf/protobuf-2.3.0-src.jar ab81e5ec2ac34541b32537e1496d02ba1f129c9e

>   third_party/runtime/protobuf/protobuf-java-2.3.0.jar f78b32b05c97c4b27f574849143935dfa8e1e5a5

>   third_party/runtime/protobuf/protobuf-java-2.5.0.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16639/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message