incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Frank R." <renfeng...@gmail.com>
Subject Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)
Date Wed, 18 Dec 2013 00:03:07 GMT
Proxy Error

The proxy server received an invalid response from an upstream server.
The proxy server could not handle the request GET /r/16322/.

Reason: Error reading from remote server

Apache/2.2.20 (Ubuntu) Server at reviews.apache.org Port 443


On Wed, Dec 18, 2013 at 12:17 AM, Yuri Zelikov <vega113@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16322/
>
> Thanks for doing this!
> Just a few quick comments, please:
> - remove commented lines
> - remove or address todos/xxx's
> - remove white spaces - they appear as red rectangles on the ReviewBoard diff
>
>
> - Yuri Zelikov
>
> On December 17th, 2013, 4:08 p.m. UTC, Frank R. wrote:
>   Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri
> Zelikov.
> By Frank R..
>
> *Updated Dec. 17, 2013, 4:08 p.m.*
>  *Repository: * wave
> Description
>
> For details (issues and commits):https://github.com/renfeng/wave
>
>   Testing
>
> tests on search box
>
> * in:inbox
> * (empty) for all, including waves shared in the domain
> * with:@
> * (free texts)
>
> tests on solr-bot
>
> * single word
> * phrase (quoted with double quotation marks)
> * syntax applicable to search box
>
>   Diffs
>
>    - run-export.sh (d2cddb7)
>    - run-import.sh (45fff8a)
>    - server.config.example (19ba8b2)
>    - src/org/waveprotocol/box/server/SearchModule.java (2de0ef9)
>    - src/org/waveprotocol/box/server/ServerMain.java (b50454d)
>    - src/org/waveprotocol/box/server/robots/agent/search/SolrRobot.java
>    (PRE-CREATION)
>    - src/org/waveprotocol/box/server/robots/agent/welcome/WelcomeRobot.java
>    (2735940)
>    - src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java
>    (PRE-CREATION)
>    - src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java
>    (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/16322/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message