incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request 16435: Move all Annotation values to a single constants class
Date Sat, 21 Dec 2013 17:01:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16435/#review30794
-----------------------------------------------------------

Ship it!


Ship It!

- Yuri Zelikov


On Dec. 21, 2013, 3:57 p.m., Ali Lown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16435/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 3:57 p.m.)
> 
> 
> Review request for wave, Joseph Gentle, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> Amazingly, all the useful constants to do with annotation keys were spread all over the
codebase, (sometimes in multiple places).
> 
> This puts them all in model/conversation (since defined in the conversation spec.), and
then updates the rest of the codebase to use them.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/doodad/link/Link.java 7b2b54a 
>   src/org/waveprotocol/wave/client/doodad/link/LinkAnnotationHandler.java 60bfe91 
>   src/org/waveprotocol/wave/client/doodad/selection/SelectionAnnotationHandler.java 158876a

>   src/org/waveprotocol/wave/client/doodad/suggestion/plugins/video/VideoLinkPlugin.java
c0105d2 
>   src/org/waveprotocol/wave/client/editor/content/misc/StyleAnnotationHandler.java 62f14f4

>   src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java 97e9064 
>   src/org/waveprotocol/wave/model/conversation/AnnotationConstants.java PRE-CREATION

>   src/org/waveprotocol/wave/model/operation/wave/WorthyChangeChecker.java d049c2e 
>   src/org/waveprotocol/wave/model/richtext/RichTextMutationBuilder.java 935c737 
> 
> Diff: https://reviews.apache.org/r/16435/diff/
> 
> 
> Testing
> -------
> 
> "ant clean get-third-party compile-gwt-dev dist-server" succeeds.
> 
> 
> Thanks,
> 
> Ali Lown
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message