incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Frank R." <renfeng...@gmail.com>
Subject Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)
Date Sat, 21 Dec 2013 13:58:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16322/#review30784
-----------------------------------------------------------



src/org/waveprotocol/box/server/robots/agent/welcome/WelcomeRobot.java
<https://reviews.apache.org/r/16322/#comment58956>

    Thanks~



src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java
<https://reviews.apache.org/r/16322/#comment58957>

    It was copied from somewhere else.



src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java
<https://reviews.apache.org/r/16322/#comment58958>

    Not too much can be refactored. The solr queries are different. So is the parsing of json.



src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java
<https://reviews.apache.org/r/16322/#comment58959>

    I added my name. It was left here as an reminder to compare with the original class, and
see if there are any feature not implemented.



src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java
<https://reviews.apache.org/r/16322/#comment58960>

    Added comment on where this was copied from. Since modifications must be made, it's not
likely to reuse the original code.



src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java
<https://reviews.apache.org/r/16322/#comment58961>

    Good point. The method name is clear enough. Will remove it.



src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java
<https://reviews.apache.org/r/16322/#comment58962>

    Will do~


- Frank R.


On Dec. 21, 2013, 1:12 a.m., Frank R. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16322/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 1:12 a.m.)
> 
> 
> Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Bugs: WAVE-311
>     https://issues.apache.org/jira/browse/WAVE-311
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> For details (issues and commits):
> https://github.com/renfeng/wave
> 
> 
> Diffs
> -----
> 
>   run-export.sh d2cddb7 
>   run-import.sh 45fff8a 
>   server.config.example 19ba8b2 
>   src/org/waveprotocol/box/server/SearchModule.java 2de0ef9 
>   src/org/waveprotocol/box/server/ServerMain.java b50454d 
>   src/org/waveprotocol/box/server/robots/agent/search/SolrRobot.java PRE-CREATION 
>   src/org/waveprotocol/box/server/robots/agent/welcome/WelcomeRobot.java 2735940 
>   src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java ee7093f 
>   src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/WaveDigester.java b103bbb 
> 
> Diff: https://reviews.apache.org/r/16322/diff/
> 
> 
> Testing
> -------
> 
> tests on search box
> 
> * in:inbox
> * (empty) for all, including waves shared in the domain
> * with:@
> * (free texts)
> 
> tests on solr-bot
> 
> * single word
> * phrase (quoted with double quotation marks)
> * syntax applicable to search box
> 
> 
> Thanks,
> 
> Frank R.
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message