incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request 12725: Assorted federation fixes
Date Sat, 17 Aug 2013 06:19:29 GMT


> On July 18, 2013, 9:09 p.m., Yuri Zelikov wrote:
> > src/org/waveprotocol/wave/model/conversation/TitleHelper.java, line 255
> > <https://reviews.apache.org/r/12725/diff/1/?file=323219#file323219line255>
> >
> >     Please put the code after "if" into brackets
> >     i.e.
> >     if () {
> >     return "";
> >     }
> 
> Ali Lown wrote:
>     Sorry, I am lazy in this respect and leave this task for whoever next comes along
and wants to change the if statement.

Well, it's up to you, but it's against the code style in this project.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12725/#review23439
-----------------------------------------------------------


On Aug. 16, 2013, 12:23 p.m., Ali Lown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12725/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2013, 12:23 p.m.)
> 
> 
> Review request for wave, Bruno Gonzalez, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Repository: wave-git
> 
> 
> Description
> -------
> 
> Federation has been broken for a while again, with assorted shiny's and server-side errors
if somebody attempted to make it work.
> 
> This patch is the squashed form of my 2013-fedfix-test branch, so to see each individual
part it is probably easiest to read the commit log at https://github.com/alown/wave/commits/2013-fedfix-test.
(Rebased against currently trunk).
> 
> This patch results in federation working again.
> It also adds assorted logging (mostly at FINE) level of useful things to enable debugging+fixing
of this section of the codebase in the future.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/frontend/ClientFrontendImpl.java 68f70a8 
>   src/org/waveprotocol/box/server/frontend/WaveletInfo.java 76fda42 
>   src/org/waveprotocol/box/server/waveserver/LocalWaveletContainer.java 2d8a891 
>   src/org/waveprotocol/box/server/waveserver/MemoryPerUserWaveViewHandlerImpl.java d995d5e

>   src/org/waveprotocol/box/server/waveserver/PerUserWaveViewDistpatcher.java f4db509

>   src/org/waveprotocol/box/server/waveserver/RemoteWaveletContainerImpl.java a48cfc6

>   src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java 4201531 
>   src/org/waveprotocol/box/server/waveserver/Wave.java 94e7a43 
>   src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java 89e03d1 
>   src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java 31fd121 
>   src/org/waveprotocol/box/webclient/client/WindowTitleHandler.java 08987b0 
>   src/org/waveprotocol/box/webclient/search/WaveBasedDigest.java e6137ce 
>   src/org/waveprotocol/wave/client/StageTwo.java 64228ab 
>   src/org/waveprotocol/wave/client/wavepanel/impl/reader/Reader.java bee1733 
>   src/org/waveprotocol/wave/model/conversation/TitleHelper.java ac2c5b3 
>   src/org/waveprotocol/wave/model/id/IdGenerator.java 5c9dec8 
>   src/org/waveprotocol/wave/model/id/IdGeneratorImpl.java 1769f92 
>   src/org/waveprotocol/wave/model/wave/opbased/WaveViewImpl.java a2cff45 
>   test/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImplTest.java 30e0c2d

>   test/org/waveprotocol/wave/concurrencycontrol/wave/CcBasedWaveViewTest.java 06e1cfc

> 
> Diff: https://reviews.apache.org/r/12725/diff/
> 
> 
> Testing
> -------
> 
> Tested by running on eezysys.co.uk and stenyak.com and verifiying.
> Verified that:
> - Local + remote waves can be made
> - Addition of remote participants results in the wave at the remote server
> - Blips can be added to a wave by either local or remote clients
> 
> - Concurrent usage isn't really tested, but then concurrent usage randomly breaks at
the moment anyway.
> 
> 
> Thanks,
> 
> Ali Lown
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message