incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Gonzalez" <sten...@gmail.com>
Subject Re: Review Request 12680: Inline only use of INDEX_WAVE_ID
Date Wed, 17 Jul 2013 16:53:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12680/#review23292
-----------------------------------------------------------


Maybe include the variable comment "The wave id of the index wave (not federated, so fake
domain)" in the new patch?

- Bruno Gonzalez


On July 17, 2013, 3:20 p.m., Ali Lown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12680/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 3:20 p.m.)
> 
> 
> Review request for wave, Bruno Gonzalez, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Repository: wave-git
> 
> 
> Description
> -------
> 
> We were maintaining a whole CommonConstants class for the single INDEX_WAVE_ID constant.
> Since the only use of this constant was a single test-case, this patch simply inlines
it there.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/common/CommonConstants.java a7497de 
>   test/org/waveprotocol/box/server/frontend/ClientFrontendImplTest.java 7d2e8c6 
> 
> Diff: https://reviews.apache.org/r/12680/diff/
> 
> 
> Testing
> -------
> 
> This builds and passes test suite.
> The composition of all 7 of these 'related' (but independent) patches is verified to
still work as a wave server.
> 
> 
> Thanks,
> 
> Ali Lown
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message