incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Gonzalez" <sten...@gmail.com>
Subject Re: Review Request 12682: Compress HistoryX files in webclient/client/ into a single file.
Date Wed, 17 Jul 2013 16:36:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12682/#review23287
-----------------------------------------------------------


It might be interesting to move some of the comments from the (now deleted) HistoryProvider.java
over to the remaining HistorySupport.java file. E.g. getToken() inline docs.

- Bruno Gonzalez


On July 17, 2013, 3:19 p.m., Ali Lown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12682/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 3:19 p.m.)
> 
> 
> Review request for wave, Bruno Gonzalez, Vicente J. Ruiz Jurado, and Yuri Zelikov.
> 
> 
> Repository: wave-git
> 
> 
> Description
> -------
> 
> Whilst perusing the code for other things to delete, I happened to spot these files.
> At which point I wondered why we had three classes doing a single-line function call
(to GWT).
> 
> As such, I compressed it all into the HistorySupport class. (Which still seems excessive,
but I will leave it there since it is still easy to change the single implementation [presuming
that was the reasoning behind using three classes in the first place]).
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/client/HistoryProvider.java f207b83 
>   src/org/waveprotocol/box/webclient/client/HistoryProviderDefault.java a2dae4a 
>   src/org/waveprotocol/box/webclient/client/HistorySupport.java 93fe852 
>   src/org/waveprotocol/box/webclient/client/WebClient.java d3e3b49 
> 
> Diff: https://reviews.apache.org/r/12682/diff/
> 
> 
> Testing
> -------
> 
> Builds and passes test suite.
> The composition of all 7 of these 'related' (but independent) patches is verified to
still work as a wave server.
> 
> 
> Thanks,
> 
> Ali Lown
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message