incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <>
Subject Review Request 12678: Remove all Memory-backed Persistence Stores
Date Wed, 17 Jul 2013 15:20:31 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for wave, Bruno Gonzalez, Vicente J. Ruiz Jurado, and Yuri Zelikov.

Repository: wave-git


Following on from the MongoDB removal, I then pondered why these Memory-backed stores still
The only reason I could come up with was the test-suite, so this patch also fixes the test-suite
to use File-backed stores.

This removes a second implementation of everything (which we have to 'test' before every release)
making that easier, removes hundreds of LOC to maintain and adjust if we want to add a new

I had also started to notice discrepancies in behaviour between implementation backings (e.g.
exceptional case behaviour differences for lucene/memory search backing).

Nobody is running an actual server using memory-backing, so we no longer have a need to keep
this code. (It was primarily developed during bootstrapping until some actual persistence

I also considered removing the config switches etc, but decided to not delete too much in
one review :P


  server.config.example 19ba8b2 
  src/org/waveprotocol/box/server/ 5beaf65 
  src/org/waveprotocol/box/server/ 2de0ef9 
  src/org/waveprotocol/box/server/persistence/ fcefc18 
  src/org/waveprotocol/box/server/persistence/ a430570 
  src/org/waveprotocol/box/server/persistence/memory/ da6a85e 
  src/org/waveprotocol/box/server/persistence/memory/ db1606a 
  src/org/waveprotocol/box/server/persistence/memory/ de0cbda 
  src/org/waveprotocol/box/server/waveserver/ 67c4ee4 
  src/org/waveprotocol/box/server/waveserver/ d995d5e

  src/org/waveprotocol/box/server/waveserver/ c5c6fe4 
  test/org/waveprotocol/box/server/authentication/ 48f905f

  test/org/waveprotocol/box/server/authentication/ 461cd03 
  test/org/waveprotocol/box/server/persistence/memory/ f89f08a 
  test/org/waveprotocol/box/server/persistence/memory/ 19fabbd 
  test/org/waveprotocol/box/server/persistence/memory/ 2e85646 
  test/org/waveprotocol/box/server/rpc/ 2e39d2d 
  test/org/waveprotocol/box/server/rpc/ 2ae4dbc 
  test/org/waveprotocol/box/server/rpc/ bd83db8 
  test/org/waveprotocol/box/server/waveserver/ 75ac795 
  test/org/waveprotocol/box/server/waveserver/ 6b09778

  test/org/waveprotocol/box/server/waveserver/ 5355e2b 
  test/org/waveprotocol/box/server/waveserver/ 89006a4

  test/org/waveprotocol/box/server/waveserver/ 30e0c2d 
  test/org/waveprotocol/box/server/waveserver/ e161490 
  test/org/waveprotocol/box/server/waveserver/ 1da4f7b 
  test/org/waveprotocol/box/server/waveserver/ 92d5baa 
  test/org/waveprotocol/box/server/waveserver/ db3e86e 



Builds and passes test suite (Junit maintains temporary directories for us).
The composition of all 7 of these 'related' (but independent) patches is verified to still
work as a wave server.


Ali Lown

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message