incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <>
Subject Review Request 12680: Inline only use of INDEX_WAVE_ID
Date Wed, 17 Jul 2013 15:20:04 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for wave, Bruno Gonzalez, Vicente J. Ruiz Jurado, and Yuri Zelikov.

Repository: wave-git


We were maintaining a whole CommonConstants class for the single INDEX_WAVE_ID constant.
Since the only use of this constant was a single test-case, this patch simply inlines it there.


  src/org/waveprotocol/box/common/ a7497de 
  test/org/waveprotocol/box/server/frontend/ 7d2e8c6 



This builds and passes test suite.
The composition of all 7 of these 'related' (but independent) patches is verified to still
work as a wave server.


Ali Lown

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message