incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request 12363: gwt updated to 2.5.1
Date Wed, 17 Jul 2013 11:24:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12363/#review23261
-----------------------------------------------------------

Ship it!


LGTM. Please commit and close.

- Ali Lown


On July 10, 2013, 10:34 a.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12363/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 10:34 a.m.)
> 
> 
> Review request for wave, Ali Lown and Yuri Zelikov.
> 
> 
> Repository: wave-git
> 
> 
> Description
> -------
> 
> Just an update of gwt to its lastest version.
> 
> I've included two new jars to avoid this compilation warning:
> (...)
> Detected warnings related to 'com.google.gwt.editor.client.SimpleBeanEditorDriver'. 
 Are validation-api-<version>.jar and validation-api-<version>-sources.jar on
the classpath?
> (...)
> 
> Jars can be downloaded from:
> http://www.gwtproject.org/download.html
> or directly from:
> http://kune.ourproject.org/kothers/gwt-2.5.1.tgz
> 
> 
> Diffs
> -----
> 
>   .classpath 725749b 
>   build.xml 763bddc 
>   test/org/waveprotocol/wave/client/editor/extract/PasteFormatRendererGwtTest.java 8f061f9

>   third_party/codegen/gwt/README.google 0a4328d 
>   third_party/codegen/gwt/gwt-dev.jar 957c8ca 
>   third_party/codegen/gwt/gwt-user.jar bfef250 
>   third_party/codegen/gwt/validation-api-1.0.0.GA-sources.jar PRE-CREATION 
>   third_party/codegen/gwt/validation-api-1.0.0.GA.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12363/diff/
> 
> 
> Testing
> -------
> 
> Normal gwt compilations, server tests, and gwt junit tests.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message