incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request 12115: Set default locale to English in selection box
Date Tue, 09 Jul 2013 11:47:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12115/#review22905
-----------------------------------------------------------


If there isn't any comment, I'll commit this in short. Thanks.

- Vicente J. Ruiz Jurado


On June 26, 2013, 6:49 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12115/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 6:49 p.m.)
> 
> 
> Review request for wave, Ali Lown, Michael MacFadden, and Yuri Zelikov.
> 
> 
> Repository: wave-git
> 
> 
> Description
> -------
> 
> Currently the Webclient selects the first locale of the drop-down select list (before
was English but not is German). This patch set English as default locale so Webclient select
it in the drop box.
> 
> Bug introduced by:
> https://reviews.apache.org/r/11948/
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/WebClientProd.gwt.xml 343cebf 
> 
> Diff: https://reviews.apache.org/r/12115/diff/
> 
> 
> Testing
> -------
> 
> Accessing to:
> http://localhost:9898
> should select English in the topbar drop-down list.
> and tested that with http://localhost:9898?locale=otherlanguages is correctly selected
in the drop-down list.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message