incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request 10328: Adds locale properties to Demo and Dev GWT configurations.
Date Fri, 28 Jun 2013 17:08:35 GMT


> On April 9, 2013, 8:20 a.m., Vicente J. Ruiz Jurado wrote:
> > src/org/waveprotocol/box/webclient/WebClientDev.gwt.xml, line 17
> > <https://reviews.apache.org/r/10328/diff/2/?file=278454#file278454line17>
> >
> >     I think is not necessary to have all the languages here, in a Dev environment.
In kune, we use two, so we can test English, and another one (a non-latin). I think is faster.

Fixed according to your comment.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10328/#review18839
-----------------------------------------------------------


On April 7, 2013, 6:33 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10328/
> -----------------------------------------------------------
> 
> (Updated April 7, 2013, 6:33 p.m.)
> 
> 
> Review request for wave, Ali Lown, Michael MacFadden, and Vicente J. Ruiz Jurado.
> 
> 
> Repository: wave-git
> 
> 
> Description
> -------
> 
> Adds locale properties to Demo and Dev GWT configurations.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/WebClientDemo.gwt.xml cd72d9b 
>   src/org/waveprotocol/box/webclient/WebClientDev.gwt.xml 362521b 
> 
> Diff: https://reviews.apache.org/r/10328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message