incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Gonzalez" <sten...@gmail.com>
Subject Re: Review Request: Enable avatar rendering in participants list
Date Mon, 10 Jun 2013 12:10:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11777/
-----------------------------------------------------------

(Updated June 10, 2013, 12:10 p.m.)


Review request for wave.


Changes
-------

Remove redundant comment as suggested by Yuri.


Description
-------

Enable the use of image avatars instead of textual avatars in the list of participants, to
make the interface consistent with the search panel list and the profile popup.


This patch is not mine, but comes directly from Ali Lown's git repository ( https://github.com/alown/wave
), commit c8f84e931315e922d632fbb1a119318d2bdc223b.


Diffs (updated)
-----

  src/org/waveprotocol/wave/client/wavepanel/render/FullDomRenderer.java cee2311 

Diff: https://reviews.apache.org/r/11777/diff/


Testing
-------

Apply patch, recompile, restart WiaB server.
Open any wave, check that there's now an image for each participant, instead of just text.


Thanks,

Bruno Gonzalez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message