incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request: Adds run-server.bat
Date Sat, 08 Jun 2013 11:15:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11746/#review21621
-----------------------------------------------------------

Ship it!


LGTM.

(Though I wonder how many people are likely to use Windows to run the server?)

- Ali Lown


On June 8, 2013, 10:47 a.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11746/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 10:47 a.m.)
> 
> 
> Review request for wave, Michael MacFadden, Vicente J. Ruiz Jurado, and Ali Lown.
> 
> 
> Description
> -------
> 
> Adds run-server.bat to provide Windows users an easier way to run the server. The batch
still misses handling of the debug parameters though.
> 
> 
> Diffs
> -----
> 
>   run-server.bat PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11746/diff/
> 
> 
> Testing
> -------
> 
> Verified that running the batch starts the server.
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message