incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Gonzalez" <sten...@gmail.com>
Subject Review Request: Fix check-certificates script
Date Thu, 06 Jun 2013 13:42:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11675/
-----------------------------------------------------------

Review request for wave.


Description
-------

Fix the check-certificates.sh script, parsing actual default configuration files.
Also fix some trailing blank characters.
Additionally, return 0 in case of success, and 1 in case of error (maybe this can be used
in conjunction with other scripts in the future).


Diffs
-----

  check-certificates.sh 68d080c 

Diff: https://reviews.apache.org/r/11675/diff/


Testing
-------

Write correct configuration into server.config and server.federation.config files,  run ./check-certificates.sh,
check that it returns 0.
Then mess with the config and cert files, run the script again, and check that it complains
and returns != 0.


Thanks,

Bruno Gonzalez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message