incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paulo Pires <pjpi...@ubiwhere.com>
Subject Re: JDK7 [Was: Maven]
Date Fri, 31 May 2013 15:35:05 GMT
With Maven, I only had an issue (with source as 1.7, because 1.6 works nicely) that I fixed
with https://github.com/pires/wave/commit/34e44e1dfb0ac6e7820f4d4b71fe05837efed960


On May 31, 2013, at 4:09 PM, Pratik Paranjape <pratikparanjape@gmail.com> wrote:

> Got it to compile and run on Ubuntu 12.10/Oracle JDK7 with following fixes:
> 1) Changed non-static references to a static method into references by
> Class name
> 2) Relaxed visibility of members from private to protected in
> AbstractTreeNode.java
> 3) Removed -Werror flag from build-macros.xml
> 4) There were test ERRORS, ignored. Couple of test failures, ignored.
> 
> To make it easy for new people, I suggest:
> 1) remove -werror flag
> 2) remove test as required step for dist during build
> 
> We can raise issues for both of these to be solved separately, because its
> not going to be a short solution. We can move
> on to adding/changing features. Build and test failures for new people can
> be discouraging.
> 
> Is there an objection on removing -werror flag altogether? Most of them are
> going to have JDK7 now and solving for
> 2000 odd warnings is not going to be easy. Many of those are about not
> parametarizing a raw type.
> 
> Regards,
> - Pratik
> 
> 
> 
> On Fri, May 31, 2013 at 11:32 AM, Bruno Gonzalez <stenyak@gmail.com> wrote:
> 
>> I confirm those were the exact errors I encountered. I was tempted to
>> disable the warning-to-error flag, but yeah it looked like a half-assed fix
>> so I directly downgraded to 6 instead.
>> 
>> 
>> On Fri, May 31, 2013 at 1:10 AM, Dave <wave@glark.co.uk> wrote:
>> 
>>> On 31/05/13 00:01, Dave wrote:
>>> 
>>>> 
>>>> I'll raise a JDK7 ticket.
>>>> 
>>> 
>>> or just find the existing ticket:
>>> 
>>> https://issues.apache.org/**jira/browse/WAVE-316<
>> https://issues.apache.org/jira/browse/WAVE-316>
>>> 
>>> Dave
>>> 
>> 
>> 
>> 
>> --
>> Saludos,
>>     Bruno González
>> 
>> _______________________________________________
>> Jabber: stenyak AT gmail.com
>> http://www.stenyak.com
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message