incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Coleman <patcole...@google.com>
Subject Re: Review Request: Line-through editor shortcut
Date Wed, 20 Mar 2013 12:55:34 GMT
The description mentions "Alt-shift-5", but it seems like you've switched
it to Ctrl-Shift-5?
Note that docs on mac has Alt-shift-5, but also the other styling options
(bold, italic, ...) are all OPTION_ rather than CTRL_ (so macs can use the
command key).

As this is a simple style shortcut, it's probably worth putting it in
EditorImpl with the others, just for simplicity, e.g:
https://gitorious.org/kune/wave/blobs/2981c4603988f263c8116cb09bdeabd854c51b73/src/org/waveprotocol/wave/client/editor/EditorImpl.java#line703


On 20 March 2013 13:34, Vicente J. Ruiz Jurado <vjrj@ourproject.org> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7548/#review18150
> -----------------------------------------------------------
>
>
> Minor change. If anybody don't have nothing to comment, I'll commit this
> in few days.
>
> - Vicente J. Ruiz Jurado
>
>
> On March 14, 2013, 1:30 p.m., Vicente J. Ruiz Jurado wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/7548/
> > -----------------------------------------------------------
> >
> > (Updated March 14, 2013, 1:30 p.m.)
> >
> >
> > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> >
> >
> > Description
> > -------
> >
> > This patch add the Alt-Shift-5 shortcut to line-through style (similar
> to google docs).
> >
> >
> > Diffs
> > -----
> >
> >   src/org/waveprotocol/wave/client/common/util/EventWrapper.java 408ac14
> >   src/org/waveprotocol/wave/client/common/util/KeyCombo.java ce571fe
> >   src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java
> dfefff5
> >
> > Diff: https://reviews.apache.org/r/7548/diff/
> >
> >
> > Testing
> > -------
> >
> > ant waveharness-hosted simple tests
> >
> >
> > Thanks,
> >
> > Vicente J. Ruiz Jurado
> >
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message