incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Review Request: Add color and backcolor buttons to edit toolbar
Date Sun, 10 Mar 2013 22:27:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9841/
-----------------------------------------------------------

Review request for wave, Michael MacFadden, Yuri Zelikov, Ali Lown, and hegsie.


Description
-------

This patch add the possibility to set color and background colors of wave text. It's something
that our users in kune were asking for and finally I decided to implement it.

Now that I'm filling this review, I see that there is some related bug and some work in progress
in #WAVE-270 (Jan-2012). I hope that can be reused and integrated with this patch (my approach
allow to integrate other color pickers). Sorry hegsie! Feel free to remix/review/improve this
patch.

You should put the new icons in src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/images/edit/


This addresses bug WAVE-270.
    https://issues.apache.org/jira/browse/WAVE-270


Diffs
-----

  src/org/waveprotocol/wave/client/testing/UndercurrentHarness.java 25abe0c 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.css 8bf9970 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java 3e196b5 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditorToolbarResources.java b5e616e

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/AbstractColorPicker.java PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/ColorHelper.java PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/ColorPopup.java PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/ComplexColorPicker.css PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/ComplexColorPicker.java PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/OnColorChooseListener.java
PRE-CREATION 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/SampleCustomColorPicker.java
PRE-CREATION 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/SimpleColorPicker.css PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/SimpleColorPicker.java PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/i18n/ColorPickerMessages.java
PRE-CREATION 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/i18n/ColorPickerMessages_en.properties
PRE-CREATION 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/i18n/ColorPickerMessages_es.properties
PRE-CREATION 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/images/edit/backcolor.png PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/images/edit/color.png PRE-CREATION


Diff: https://reviews.apache.org/r/9841/diff/


Testing
-------

Some text editions... setting/unsetting colors.


Thanks,

Vicente J. Ruiz Jurado


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message