incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: Fixed so that GadgetWidget properly use its saved height for faster wave loading
Date Mon, 04 Mar 2013 11:09:09 GMT


> On Feb. 28, 2013, 2:16 a.m., Vicente J. Ruiz Jurado wrote:
> > Sorry but since this review was applied several gadgets are not setting its height
correctly. 
> > 
> > For instance this:
> > http://mass-mob.appspot.com/massmob/org.ourproject.massmob.client.MassmobGadget.gadget.xml
> > that uses adjustHeight gadget feature.
> > https://developers.google.com/gadgets/docs/ui?hl=en#Dyn_Height
> > 
> > so I propose to revert back this patch til this is fixed.

"The cure may be worse than the disease". If no one have comments in few days I'll revert
this patch. 


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8008/#review17181
-----------------------------------------------------------


On Nov. 10, 2012, 4:50 p.m., rocklund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8008/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 4:50 p.m.)
> 
> 
> Review request for wave.
> 
> 
> Description
> -------
> 
> GadgetWidget already have a saved height property to be able to load its correct height
faster when a wave is loaded. This property was however not properly used so gadget heights
got changed several times during wave loading, forcing the user to wait until all gadgets
was loaded until he/she could start to read the wave.
> 
> This patch fixes so that gadgets load with their saved heights if they have any. A new
height is saved when the user perform an action on the gadget that causes its height to be
changed. This greatly improves the perceived load time of waves with many gadgets.
> 
> 
> Please review, thanks!
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidget.java f89abfd 
>   src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidgetUi.java 50b205d 
> 
> Diff: https://reviews.apache.org/r/8008/diff/
> 
> 
> Testing
> -------
> 
> Tested on locally run server with most of the gadgets. Trying both the more static gadgets
and the gadgets that have more dynamic heights.
> 
> 
> Thanks,
> 
> rocklund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message